-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Tooling] Draft: Upload app metrics #16580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APKs: |
Rats: WPAndroid is still using CircleCi and its In practice CircleCI only calls those So in its current state my demo here won't work on Installable Builds, only on Alpha, Beta and Final Releases. |
833af84
to
7a4f7ac
Compare
Which implies Jalapeno Debug Universal APK (and no AAB)
7a4f7ac
to
2b54143
Compare
This has now been fixed:
With that new change, you can see that the payload for both WordPress and Jetpack app metrics have been properly generated and saved as artifacts for the CI (until we get a proper runnin Metrics server to send them to). |
Note: this PR Draft was initially created to test that the new But I'm not yet sure we'd really want to send app size metrics for every Installable Build like what this Demo PR does here — and thus size data for "Universal APKs" — in practice once the Metrics server goes live (as opposed to limit it to only send data for betas and final builds, and thus size data for
|
My two cents on whether to send app size data for every Installable Build is that we should not do it just yet. Alongside @AliSoftware legitimate questions about having too much data, there's also the fact that we are just starting out with this project. It seems wise to start small and add the extra information later on. And while it's true that it's better to have more data and filter it out than to not have it and regret it, I think that applies more for analytics that can allow to understand user behavior (where more details give better insight) or in an even sourcing service (where you might want to replay the whole collection of events through a more advanced ML model in the future). In our case, we're talking about how the app size varies between commits on a feature branch. I think we can live with less granularity in this instance. |
🚧 This is WIP to test the new App Size Metrics API and fastlane action implemented in wordpress-mobile/release-toolkit#364
Internal Reference: paaHJt-3od-p2