Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MVC 구현하기 - 3단계] 짱수(장혁수) 미션 제출합니다. #840
base: zangsu
Are you sure you want to change the base?
[MVC 구현하기 - 3단계] 짱수(장혁수) 미션 제출합니다. #840
Changes from 6 commits
d983eb8
538ed8b
61e8883
44d1771
f95547c
457420f
273ad5f
047876d
c6487f1
b1ed677
6cdd040
3d40a74
7ca2947
f447f51
4144e07
dc16972
09adbde
083c2f8
9ae262c
d3b2066
d87ddd1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JspView
이름에서 충분히 유추 가능하기 때문에 �확장자까지 주입할 필요는 없을거 같아요!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
파라미터로 전달되는
viewName
의 값을 말하시는거죠?하지만, 이 부분은 "파일 이름" 을 전달하는 부분이라 확장자가 없는 것이 더 어색할 것 같은데,,, 어떻게 생각하실까요?? 🤔
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"account" parameter가 2개 이상이면 어떻게 될까요?🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그런 경우 첫번째로 전달된 파라미터의 값만 확인해주고 있네요.
그런데, 또 API 자체가 하나의 account 파라미터를 지원한다고 명시했을 때 여러개의 쿼리 파라미터 요청을 고려해 주는 것이 맞을지,,, 고민은 됩니다.
This file was deleted.
This file was deleted.
This file was deleted.