[MVC 구현 - 3단계] 홍실(홍혁준) 미션 제출합니다.#620
Merged
jundonghyuk merged 18 commits intowoowacourse:hong-silefrom Sep 26, 2023
Merged
Conversation
jundonghyuk
requested changes
Sep 25, 2023
jundonghyuk
left a comment
jundonghyuk
left a comment
There was a problem hiding this comment.
안녕하세요 홍실 ! 고생하셨슴다 !
너무 잘 구현해주셔서 리뷰할게 좀 적네요 ...
궁금한게 있어서 몇 개 달아놨습니다 !
다음 번에는 머지해도 될 것 같습니다 ~
...ebmvc/org/springframework/web/servlet/mvc/tobe/handler_mapping/AnnotationHandlerMapping.java
Outdated
Show resolved
Hide resolved
mvc/src/main/java/webmvc/org/springframework/web/servlet/view/JsonView.java
Outdated
Show resolved
Hide resolved
Comment on lines
+24
to
+27
| if (model.size() == 1) { | ||
| return objectMapper.writeValueAsString(model.values().toArray()[0]); | ||
| } | ||
| return objectMapper.writeValueAsString(model); |
Comment on lines
+42
to
+44
| @DisplayName("JspView render Test 값이 두개 이상일 떄") | ||
| void renderTest2() throws Exception { | ||
| final JsonView jsonView = new JsonView(); |
|
SonarCloud Quality Gate failed.
|
jundonghyuk
approved these changes
Sep 26, 2023
jundonghyuk
left a comment
jundonghyuk
left a comment
There was a problem hiding this comment.
홍실 고생하셨습니다 ㅎㅎ
MVC미션에서 함께해서 재밌었습니다 ^_^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
하디 안녕하세요
이번 3단계 미션에서는 JSON, JSP View를 구현했습니다.
그리고 레거시 MVC도 제거했습니다.
이번 리뷰도 잘 부탁드립니다.(늦게 보내드려 죄송하네요)
가감없이 리뷰해주시면 감사하겠습니다.