[MVC 구현하기 - 3단계] 베베(최원용) 미션 제출합니다 #617
Merged
Merged
Conversation
SproutMJ
requested changes
Sep 25, 2023
SproutMJ
left a comment
SproutMJ
left a comment
There was a problem hiding this comment.
안녕하세요 베베, 미션 구현하신 코드 잘 봤습니다.
제가 확인 한 부분은 asis 패키지에 아직 레거시 컨트롤러?가 남아있는 것 같고요, 두 번째는 css, js 같은 정적 리소스를 가져오지 못하는 것 같은데 이부분은 사용 환경이 달라서일 수도 있습니다.
이에 대해서 답변 주시면 바로 approve 하겠습니다. 감사합니다.
| final var dispatcherServlet = new DispatcherServlet(); | ||
| dispatcherServlet.addHandlerMapping(new LegacyHandlerMapper()); | ||
| dispatcherServlet.addHandlerMapping(new AnnotationHandlerMapper("com")); | ||
| dispatcherServlet.addHandlerAdapter(new CustomControllerAdapter()); |
There was a problem hiding this comment.
혹시 레거시 코드를 제거할 때 이부분도 제거되어야 하는지 궁금합니다!
예를들어 제거 대상으로 webmvc.org.springframework.web.servlet.mvc.asis에 유지되어 있는 클래스들이 있겠네요.
Member
Author
There was a problem hiding this comment.
요구사항에서 Legacy 코드를 모두 제거해라고 하여서 제거 했는데, 원래 사용하던 LegacyHandlerMapper를 사용하지 않게 되면서 삭제했습니다!
SproutMJ
approved these changes
Sep 25, 2023
SproutMJ
left a comment
SproutMJ
left a comment
There was a problem hiding this comment.
미션 요구사항을 충족하신 것 같아서 approve 했습니다.
정적 리소스 문제는 제 환경에 문제가 있던 것 같네요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안녕하세요 엔델! 우선 3단계 요구사항을 지키려고 노력했습니다! DispatcherServlet은 mvc 패키지로 이동하고, DispatcherServletInitializer는 그대로 뒀습니다 ㅠ 이번 리뷰도 잘 부탁드려요!