-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MVC 구현하기 - 3단계] 엔초(권예진) 미션 제출합니다. #575
Changes from 8 commits
9f56f7b
f67d5cc
f4ce0ae
51aeb96
a039fd8
bf0005e
fdad8f7
508467a
db7853e
e5ccb8e
6e750e4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package com.techcourse.controller; | ||
|
||
import context.org.springframework.stereotype.Controller; | ||
import jakarta.servlet.http.HttpServletRequest; | ||
import jakarta.servlet.http.HttpServletResponse; | ||
import web.org.springframework.web.bind.annotation.RequestMapping; | ||
import web.org.springframework.web.bind.annotation.RequestMethod; | ||
import webmvc.org.springframework.web.servlet.ModelAndView; | ||
import webmvc.org.springframework.web.servlet.view.JspView; | ||
|
||
@Controller | ||
public class ForwardController { | ||
|
||
private static final String PATH = "/index.jsp"; | ||
|
||
@RequestMapping(value = "/", method = RequestMethod.GET) | ||
public ModelAndView execute(final HttpServletRequest request, final HttpServletResponse response) { | ||
return new ModelAndView(new JspView(PATH)); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
package com.techcourse.controller; | ||
|
||
import com.techcourse.domain.User; | ||
import com.techcourse.repository.InMemoryUserRepository; | ||
import context.org.springframework.stereotype.Controller; | ||
import jakarta.servlet.http.HttpServletRequest; | ||
import jakarta.servlet.http.HttpServletResponse; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
import web.org.springframework.web.bind.annotation.RequestMapping; | ||
import web.org.springframework.web.bind.annotation.RequestMethod; | ||
import webmvc.org.springframework.web.servlet.ModelAndView; | ||
import webmvc.org.springframework.web.servlet.view.JsonView; | ||
|
||
@Controller | ||
public class UserController { | ||
|
||
private static final Logger log = LoggerFactory.getLogger(UserController.class); | ||
|
||
@RequestMapping(value = "/api/user", method = RequestMethod.GET) | ||
public ModelAndView show(HttpServletRequest request, HttpServletResponse response) { | ||
final String account = request.getParameter("account"); | ||
log.info("user id : {}", account); | ||
|
||
final ModelAndView modelAndView = new ModelAndView(new JsonView()); | ||
final User user = InMemoryUserRepository.findByAccount(account) | ||
.orElseThrow(); | ||
|
||
modelAndView.addObject("user", user); | ||
return modelAndView; | ||
} | ||
} |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package com.techcourse; | ||
package webmvc.org.springframework.web.servlet.mvc; | ||
|
||
import jakarta.servlet.ServletException; | ||
import jakarta.servlet.http.HttpServlet; | ||
|
@@ -7,12 +7,7 @@ | |
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
import webmvc.org.springframework.web.servlet.ModelAndView; | ||
import webmvc.org.springframework.web.servlet.mvc.HandlerAdapter; | ||
import webmvc.org.springframework.web.servlet.mvc.HandlerAdapterRegistry; | ||
import webmvc.org.springframework.web.servlet.mvc.HandlerMappingRegistry; | ||
import webmvc.org.springframework.web.servlet.mvc.asis.ControllerHandlerAdapter; | ||
import webmvc.org.springframework.web.servlet.mvc.tobe.AnnotationHandlerMapping; | ||
import webmvc.org.springframework.web.servlet.mvc.tobe.HandlerExecutionHandlerAdapter; | ||
import webmvc.org.springframework.web.servlet.view.JspView; | ||
|
||
import java.util.Optional; | ||
|
||
|
@@ -23,34 +18,39 @@ public class DispatcherServlet extends HttpServlet { | |
|
||
private final HandlerMappingRegistry handlerMappingRegistry = new HandlerMappingRegistry(); | ||
private final HandlerAdapterRegistry handlerAdapterRegistry = new HandlerAdapterRegistry(); | ||
private HandlerExecutor handlerExecutor; | ||
|
||
public DispatcherServlet() { | ||
} | ||
|
||
@Override | ||
public void init() { | ||
handlerMappingRegistry.addHandlerMapping(new ManualHandlerMapping()); | ||
handlerMappingRegistry.addHandlerMapping(new AnnotationHandlerMapping(Application.class.getPackageName() + ".*")); | ||
handlerAdapterRegistry.addHandlerAdapter(new ControllerHandlerAdapter()); | ||
handlerAdapterRegistry.addHandlerAdapter(new HandlerExecutionHandlerAdapter()); | ||
handlerExecutor = new HandlerExecutor(handlerAdapterRegistry); | ||
} | ||
|
||
public void addHandlerMapping(final HandlerMapping handlerMapping) { | ||
handlerMappingRegistry.addHandlerMapping(handlerMapping); | ||
} | ||
|
||
public void addHandlerAdapter(final HandlerAdapter handlerAdapter) { | ||
handlerAdapterRegistry.addHandlerAdapter(handlerAdapter); | ||
} | ||
|
||
@Override | ||
protected void service(final HttpServletRequest request, final HttpServletResponse response) { | ||
protected void service(final HttpServletRequest request, final HttpServletResponse response) throws ServletException { | ||
final String requestURI = request.getRequestURI(); | ||
log.debug("Method : {}, Request URI : {}", request.getMethod(), requestURI); | ||
|
||
final Optional<Object> nullableHandler = handlerMappingRegistry.getHandler(request); | ||
|
||
if (nullableHandler.isEmpty()) { | ||
response.setStatus(HttpServletResponse.SC_NOT_FOUND); | ||
render(new ModelAndView(new JspView("404.jsp")), request, response); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍👍 |
||
return; | ||
} | ||
|
||
final Object handler = nullableHandler.get(); | ||
try { | ||
final HandlerAdapter handlerAdapter = handlerAdapterRegistry.getHandlerAdapter(handler); | ||
final ModelAndView modelAndView = handlerAdapter.handle(request, response, handler); | ||
final ModelAndView modelAndView = handlerExecutor.handle(request, response, handler); | ||
render(modelAndView, request, response); | ||
} catch (Exception e) { | ||
throw new RuntimeException(e); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이번에 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. handleNotFound 메서드를 추가해서 404 ModelAndView를 반환하도록 수정했습니다! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 확인했습니다! |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package webmvc.org.springframework.web.servlet.mvc; | ||
|
||
import jakarta.servlet.http.HttpServletRequest; | ||
import jakarta.servlet.http.HttpServletResponse; | ||
import webmvc.org.springframework.web.servlet.ModelAndView; | ||
|
||
public class HandlerExecutor { | ||
|
||
private final HandlerAdapterRegistry handlerAdapterRegistry; | ||
|
||
public HandlerExecutor(final HandlerAdapterRegistry handlerAdapterRegistry) { | ||
this.handlerAdapterRegistry = handlerAdapterRegistry; | ||
} | ||
|
||
public ModelAndView handle(final HttpServletRequest request, final HttpServletResponse response, Object handler) throws Exception { | ||
final HandlerAdapter handlerAdapter = handlerAdapterRegistry.getHandlerAdapter(handler); | ||
return handlerAdapter.handle(request, response, handler); | ||
} | ||
} |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 이 부분을 보면
☺️
HandlerExecutor
의 경우DispatcherServlet
의init()
메소드에서 초기화가 되는데HandlerMapping
과HandlerAdapter
의 경우에는DispatcherServletInitializer
에서 값을 추가하는 방식으로 구현을 해주셨어요. 이 부분을 분리해서 값을 추가해주신 이유가 있을까요?혹시 AnnotationHandler의 basePackage 설정을 위함일까요?
엔초의 생각흐름이 궁금합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addHandlerMapping
과addHandlerAdapter
는DispatcherServletInitializer
의onStartUp()
에서 직접 호출하고 있고,DispatcherServlet
의init()
은onStartUp()
이 끝난 후에 호출이 되고 있습니다.HandlerExecutor
는HandlerAdapterRegistry
를 사용하기 때문에HandlerAdapterRegistry
에 대한 설정이 끝난 이후에 사용되어야 한다고 생각했습니다.init()
메서드가HandlerAdapterRegistry
를 설정해주는onStartUp()
이 끝난 후에 호출되기 때문에 이렇게 분리하면 더 명확하다고 생각했습니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 이해 완료했습니다! 자세하게 답변해주셔서 감사합니다!