[MVC 구현하기 - 1단계] 마코(이규성) 미션 제출합니다. #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevstevie
approved these changes
Sep 13, 2023
| Arrays.stream(methods) | ||
| .filter(this::supportParameters) | ||
| .filter(method -> method.isAnnotationPresent(RequestMapping.class)) | ||
| .forEach(method -> putHandlerExecutions(handler, method)); |
There was a problem hiding this comment.
https://tecoble.techcourse.co.kr/post/2020-05-14-foreach-vs-forloop/
foreach에 로직이 들어가면 안된다는데 어떻게 생각하시나요
근데 저도 foreach로 map에 넣는 작업을 수행하긴 했습니다
There was a problem hiding this comment.
좋은 아티클 공유 감사합니다👍
for-loop보다 짧은 코드로 해결하려고 애써 외면하고 이 정도는 괜찮겠지 하고 타협했던 문제인데 충분히 로직을 빼고 스트림으로 해결할 수 있을 것 같네요. 2단계에서 리팩토링 해보겠습니다~
| log.info("Initialized AnnotationHandlerMapping!"); | ||
| } | ||
|
|
||
| private boolean supportParameters(final Method method) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi~ 주드 👋
AnnotationHandlerMappingTest가 통과하도록 구현했습니다.구현한 방법은 다음과 같습니다.
@Controller애너테이션이 붙은 클래스들을 찾음.@RequestMapping이 붙은 메서드들을 찾음.HandlerKey와HandlerExecution을 생성하여Map<HandlerKey, HandlerExecution>에 삽입.잘 부탁드립니다~🙏