[JDBC 라이브러리 구현하기 - 1단계] 이오(이지우) 미션 제출합니다. #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-mallang
requested changes
Sep 30, 2023
| public UserDao(final DataSource dataSource) { | ||
| this.dataSource = dataSource; | ||
| } | ||
| private final RowMapper<User> rowMapper = (rs, rowNum) -> |
There was a problem hiding this comment.
staic이어야 한다는 생각을 미처 못했는데, 필드가 변하지 않으니 static인 편이 더 적절하겠네요! 반영하였습니다.
static을 반영하면서 static final이 되었는데, 말랑은 RowMapper도 상수로 취급하는게 옳다고 생각하시는지 궁금합니다!
(저는 우선 상수라고 생각하여 네이밍을 uppercase로 변경하였습니다.)
There was a problem hiding this comment.
저는 음.. 변하지는 않으니 상수인 것 같다고는 생각하지만, 일반적으로 primitive나 String이 아니고서야 다 소문자로 쓰는 것 같네요 ..ㅎㅎ
그냥 이건 정해진 방법이 없는 것 같아서 제가 보기 편한대로 사용한답니다..
jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java
Outdated
Show resolved
Hide resolved
jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java
Outdated
Show resolved
Hide resolved
jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java
Outdated
Show resolved
Hide resolved
|
안녕하세요 말랑! |
shin-mallang
approved these changes
Oct 1, 2023
Comment on lines
17
to
18
| ); | ||
| private final JdbcTemplate jdbcTemplate; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 말랑!
리뷰 잘부탁드립니다 😊
이번 단계에서는 구현한 코드가 많지 않아서 코멘트 남길 부분은 별로 없네요.
즐거운 한가위 되세요! 😃