Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JDBC 라이브러리 구현하기 - 1단계] 오잉(이하늘) 미션 제출합니다. #283

Merged
merged 15 commits into from
Sep 29, 2023

Conversation

hanueleee
Copy link

@hanueleee hanueleee commented Sep 27, 2023

안녕하세요 제나!
리뷰어 리뷰이로 만나다니 너무너무 반갑네요😋

UserDao에 있던 로직들을 JdbcTemplate으로 간단하게 옮겨보았습니다~~
이번 미션 잘 부탁드려요👨‍🎤

커밋 범위

@hanueleee hanueleee self-assigned this Sep 27, 2023
if (pstmt != null) {
pstmt.close();
}
} catch (SQLException ignored) {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이 무시하면 어떡해요~

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여우 메롱

Copy link

@yenawee yenawee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 오잉!
추석 연휴는 잘 보내고 계신가요?

3번째 미션 리뷰로 만나게 되어서 반갑습니다 😊

첫번째 미션 넘 깔끔하게 진행해주셔서 몇가지 코멘트만 확인해주시면 될거같아요
남긴 코멘트가 2단계 리팩터링미션의 요구사항과 관련된 것 같아 1단계는 머지하겠습니다!

1단계 미션 진행하시느라 수고하셨고 담 단계에서 만나용 👏👏

@yenawee yenawee merged commit 81363a4 into woowacourse:hanueleee Sep 29, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants