[톰캣 구현하기 3, 4단계] 호이(이건호) 미션 제출합니다. #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SproutMJ
requested changes
Sep 12, 2023
Comment on lines
9
to
16
| @Override | ||
| public void service(HttpRequest request, HttpResponse response) throws Exception { | ||
| if (request.isGetMethod()) { | ||
| doGet(request, response); | ||
| return; | ||
| } | ||
| doPost(request, response); | ||
| } |
| import org.apache.coyote.http11.request.HttpRequest; | ||
| import org.apache.coyote.http11.response.HttpResponse; | ||
|
|
||
| public class ErrorController implements Controller { | ||
| public class ErrorController extends AbstractController { |
| @@ -14,43 +14,20 @@ | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
|
|
|||
| public class LoginController implements Controller { | |||
| public class LoginController extends AbstractController { | |||
|
|
|||
| private static final Logger log = LoggerFactory.getLogger(LoginController.class); | |||
There was a problem hiding this comment.
로깅은 사용하지 않고 있습니다. 기존 뼈대 코드에 있던 거라 나뒀는데 삭제하도록 하겠습니다!
Comment on lines
+43
to
46
| public HttpResponse statusCode(final StatusCode statusCode) { | ||
| this.statusCode = statusCode; | ||
| return this; | ||
| } |
There was a problem hiding this comment.
빌더 패턴을 이용해서 객체를 생성하게 한건가요? 좋은 것 같습니다.
다만, 이를 이용해 생성할 때 기본값이 있을까요? 만약 없으면 세팅을 하기 않으면 문제가 발생할까요?
SproutMJ
requested changes
Sep 12, 2023
SproutMJ
requested changes
Sep 12, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요. 엔델
3단계 요구사항 까지 구현은 했는데
4단계는 아직 구현을 다 못했습니다..
4단계는 3단계 요구사항과 같이 반영해도 될까요?