[톰캣 구현하기 - 3, 4단계] 오잉(이하늘) 미션 제출합니다. #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanueleee
changed the title
jundonghyuk
requested changes
Sep 10, 2023
tomcat/src/main/java/org/apache/coyote/http11/Http11Processor.java
Outdated
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/common/request/HttpRequest.java
Outdated
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/common/response/HttpResponse.java
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/common/response/ResponseHeaders.java
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/servlet/NotFoundServlet.java
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/servlet/RegisterServlet.java
Outdated
Show resolved
Hide resolved
jundonghyuk
reviewed
Sep 10, 2023
tomcat/src/main/java/org/apache/coyote/http11/common/response/ResponseHeaders.java
Show resolved
Hide resolved
jundonghyuk
reviewed
Sep 10, 2023
tomcat/src/main/java/org/apache/coyote/http11/common/response/HttpResponse.java
Show resolved
Hide resolved
|
안녕하세요 하디! 주요 변경지점은 다음과 같습니다.
그런데 뭔가..? Servlet 내부 코드가 좀 그렇네요.. 그리고 servlet별로 다른 allowedMethod를 어떻게 상위클래스로 넘길 수 있을지 고민하다가, 생성자에서 super로 넘겨서 세팅하는 방식을 택했는데 혹시 어떻게 생각하시나요?! |
jundonghyuk
reviewed
Sep 11, 2023
tomcat/src/main/java/org/apache/coyote/http11/servlet/RegisterServlet.java
Outdated
Show resolved
Hide resolved
jundonghyuk
reviewed
Sep 11, 2023
tomcat/src/main/java/org/apache/coyote/http11/servlet/Servlet.java
Outdated
Show resolved
Hide resolved
jundonghyuk
approved these changes
Sep 12, 2023
jundonghyuk
reviewed
Sep 12, 2023
tomcat/src/main/java/org/apache/coyote/http11/servlet/Servlet.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 하디 🕺
이번 미션 3,4단계 완료했습니다!
3단계(리팩토링)를 진행하다보니 수정사항이 꽤 많이 생겼습니다 ㅎㅎ..
Servlet
기존 Servlet의 handle메소드는 Request를 파라미터로 받아 적절한 Response를 반환했습니다.
수정 후 Servlet의 service메소드가 Request, Response를 모두 파라미터로 받고,
service 로직 속에서 response에 적절한 값을 세팅해주게 되었습니다.
MethodNotAllowedException & BadRequestException
허용하지 않는 메소드이거나 잘못된 요청인 경우 error를 발생시키고
Http11Processor에서 해당 error를 잡아 적절한 response를 세팅하도록 수정했습니다.
HttpHeaders -> RequestHeaders & ResponseHeaders
HttpRequest, HttpResponse 모두에서 사용되던 HttpHeaders를 RequestHeaders와 ResponseHeaders로 분리했습니다.
이번 리뷰도 잘 부탁드립니다!! 🙇♀️