[톰캣 구현하기 - 3, 4단계] 헙크(정현승) 미션 제출합니다. #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BGuga
reviewed
Sep 10, 2023
tomcat/src/main/java/org/apache/coyote/http11/controller/AbstractController.java
Outdated
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/response/StaticResource.java
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/controller/Controller.java
Outdated
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/controller/IndexController.java
Outdated
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/controller/IndexController.java
Outdated
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/response/ResponseBody.java
Outdated
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/response/ResponseBody.java
Outdated
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/response/ResponseHeaders.java
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/response/HttpResponse.java
Show resolved
Hide resolved
BGuga
requested changes
Sep 10, 2023
|
푸우우 좋은 피드백 주셔서 감사합니다ㅎㅎㅎ 푸우의 피드백과 더불어, 슬랙에서 확인해보니 주어진 Controller와 AbstractController를 수정하면 안된다는 것을 뒤늦게 확인했습니다. 그래서 요구사항에 맞게 다시 전체적인 구조를 수정하였습니다. 감안하고 봐주시면 좋을 것 같네요 ㅎㅎㅎ |
BGuga
requested changes
Sep 11, 2023
BGuga
approved these changes
Sep 13, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 푸우우. 다시 돌아왔습니다 ㅎㅎㅎ
기존 구조에서 크게 달라진 것은 없고, 3단계에서 Controller 구조를 도입한 부분만 크게 달라졌습니다. 추가적으로 테스트를 넣어봤습니다. 감사합니다 :)