[빙티] 회원가입 미션 3, 4단계 제출합니다. #25
Open
+427
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md # app/src/main/java/nextstep/signup/ui/SignUpScreen.kt # app/src/main/java/nextstep/signup/ui/SignUpTextField.kt # app/src/main/java/nextstep/signup/ui/theme/Theme.kt # app/src/main/res/values/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 채드!
3,4단계도 잘 부탁드려용~
asdf.mp4
구현 목록
SignUpFormdata class : 각 입력값의 유효성과 폼 전체의 제출 가능 여부 검사 로직을 담은 클래스ValidationStateenum class : 유효성 상태를 위한 클래스 (유효한 상태,형식 에러 상태,길이 에러 상태)SignUpTextField: @composable 파라미터인 getErrorMessage를 SignUpScreen에서 주입하도록 수정SignUpFormTest:SignUpForm의 유닛 테스트 추가SignUpTextFieldKtTest:SignUpTextField의 UI 테스트 추가고민
에러 메시지는 다국어 지원 등을 고려해 stringResource에 위치해야 한다고 판단했습니다.
그런데 요구사항에 따르면
입력 형식 에러,문자열 길이 에러등 여러 종류의 에러 문구가 존재하고 있습니다.각 에러 상황에 따라 적절한 문구를 띄워주기 위해서 어떤 에러 상태를 나타내는 ValidationState 클래스를 추가해주었는데,
적절한 구조인지 잘 모르겠네요,,😅