-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE-INFRA] 개발 DB 서버 설정 #347
Conversation
추가된 변경 사항
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! LGTM!
질문 하나만 달았는데 확인해주세요! 😄
@@ -66,5 +66,5 @@ jobs: | |||
docker run -d -p 8080:8080 --name server \ | |||
-e JAVA_OPTS="-XX:InitialRAMPercentage=70.0 -XX:MaxRAMPercentage=70.0" \ | |||
-e TZ=Asia/Seoul \ | |||
-e SPRING_PROFILES_ACTIVE=local \ | |||
-e SPRING_PROFILES_ACTIVE=dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
드디어 개발 환경을 사용해보는 군요 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제대로 된 개발 환경 냠냠
@@ -17,7 +17,7 @@ jobs: | |||
|
|||
build: | |||
needs: test | |||
runs-on: cd | |||
runs-on: [cd, app-a] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
서브넷을 뜻하는 a 일까요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 맞습니다! 우테코에서 제공해준 서브넷 이름이 app-a 더라고요!
이 pr에 포함시켜야 하나 헷갈렸는데 현재 cd tag를 가진 runner가 두 개여서 (app-b를 생성함) 안전하게 설정해뒀습니다
/noti @폴라 코멘트 달아뒀어요! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
데황 미아
🍄 PR 확인 사항
PR이 다음 요구 사항을 충족하는지 확인하세요. :
현재 작업은 어떤 이슈를 해결한 것인지 설명해주세요.
기존 코드에서 변경된 점이 있다면 설명해주세요. (추가 X)
이 PR 역시 다른 PR들보다 먼저 머지된다면 다른 PR이 개발 서버에 배포 돼도 오류 없이 MongoDB에 연결돼서 작동할 수 있습니다 🙂