[BE-REFACTOR] 배틀 기능 MongoDB 사용하도록 리팩토링 #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4-pokerogue-helper into be/refactor/#331-refactor-battle-api
jinchiim
requested changes
Sep 26, 2024
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/DataInitializer.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/data/TypeMatching.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/data/Weather.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/service/BattleMultiplier.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/service/BattleService.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/service/BattleService.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/service/TypeMultiplierProvider.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/test/java/com/pokerogue/helper/battle/data/WeatherTest.java
Outdated
Show resolved
Hide resolved
...kerogue/src/test/java/com/pokerogue/helper/battle/repository/TypeMatchingRepositoryTest.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/service/BattleService.java
Outdated
Show resolved
Hide resolved
unifolio0
reviewed
Sep 26, 2024
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/service/BattleMultiplier.java
Outdated
Show resolved
Hide resolved
unifolio0
approved these changes
Sep 26, 2024
|
/noti @폴라 리뷰 반영 및 코멘트 달았습니당! |
jinchiim
approved these changes
Sep 26, 2024
dwax1324
requested changes
Sep 26, 2024
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/service/BattleCalculator.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/service/BattleMultiplier.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/service/BattleMultiplier.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/service/TypeMultiplierProvider.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/service/TypeMultiplierProvider.java
Show resolved
Hide resolved
...kerogue/src/test/java/com/pokerogue/helper/battle/service/WeatherMultiplierProviderTest.java
Show resolved
Hide resolved
backend/pokerogue/src/test/java/com/pokerogue/helper/battle/service/WeatherServiceTest.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/test/java/com/pokerogue/helper/pokemon/data/PokemonTest.java
Outdated
Show resolved
Hide resolved
backend/pokerogue/src/test/java/com/pokerogue/helper/battle/service/BattleMultiplierTest.java
Show resolved
Hide resolved
backend/pokerogue/src/test/java/com/pokerogue/helper/battle/service/BattleMultiplierTest.java
Outdated
Show resolved
Hide resolved
|
/noti @종이 : 모두 반영 및 코멘트 남겼습니다! |
dwax1324
approved these changes
Sep 27, 2024
backend/pokerogue/src/main/java/com/pokerogue/helper/battle/service/BattleMultiplier.java
Show resolved
Hide resolved
jongmee
force-pushed
the
be/refactor/#331-refactor-battle-api
branch
from
e1ad0b3
to
ee8ff8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍄 PR 확인 사항
PR이 다음 요구 사항을 충족하는지 확인하세요. :
현재 작업은 어떤 이슈를 해결한 것인지 설명해주세요.
기존 코드에서 변경된 점이 있다면 설명해주세요. (추가 X)
이 부분을 위주로 봐주세요!
이 PR은 앞선 PR들 머지되고 충돌 해결 후 머지할 예정입니다. 코드 리뷰 때문에 미리 올려요~!
배틀 패키지에서 패키지 분리가 된 클래스들 위주로 리뷰해주시면 됩니다 😄 + 테스트코드
고민사항
도메인패키지가 없어서BattleMultiplier를 그냥 서비스 패키지에 넣었는데 고민됩니다..도메인 패키지를 만드는게 좋을까요?
TypeMultiplierProvider이름 괜찮나요??TypeBattingMultiplierProvider가 나을까요?고민하다가 둘 다 그저 그래서 의견을 받고 싶습니다 😅