[BE-REFACTOR] Biome, Move 정보 MongoDB 사용하도록 리팩토링 #335

unifolio0 · 2024-09-25T10:55:17Z

🍄 PR 확인 사항

PR이 다음 요구 사항을 충족하는지 확인하세요. :

API 명세서가 업데이트 혹은 작성이 되어 있나요?

현재 작업은 어떤 이슈를 해결한 것인지 설명해주세요.

Issue Number: #332

기존 코드에서 변경된 점이 있다면 설명해주세요. (추가 X)

있음
없음

biome 및 move 전부 mongo로 작동하도록 수정

unifolio0 · 2024-09-25T11:23:34Z

/noti

ci까지 통과했습니다!

jongmee

고생하셨습니다!!! 👍 최고!!! 리뷰 좀 남겨봤어요 🕊️

(포켓몬 패키지가 좀 변경되었던데 종이 작업에서 충돌날까봐 살짝 걱정되네요 🥺)

backend/pokerogue/src/main/java/com/pokerogue/helper/biome/data/BiomePokemonType.java

backend/pokerogue/src/main/java/com/pokerogue/helper/biome/service/BiomeService.java

backend/pokerogue/src/main/java/com/pokerogue/helper/biome/data/NativePokemon.java

backend/pokerogue/src/main/java/com/pokerogue/helper/biome/service/BiomeService.java

backend/pokerogue/src/main/java/com/pokerogue/helper/move/controller/MoveController.java

backend/pokerogue/src/main/java/com/pokerogue/helper/move/service/MoveService.java

backend/pokerogue/src/main/java/com/pokerogue/helper/pokemon/dto/PokemonMoveResponse.java

backend/pokerogue/src/test/java/com/pokerogue/helper/battle/BattleServiceTest.java

jinchiim

안녕하세요 비토! 수고 많으셨습니다!

리팩토링도 함께 가져가기로 했으니 보이는 부분 전부 리뷰해봤어요!
확인 부탁드려요! ☺️

backend/pokerogue/src/main/java/com/pokerogue/helper/biome/data/Biome.java

backend/pokerogue/src/main/java/com/pokerogue/helper/biome/data/BiomePokemonType.java

backend/pokerogue/src/main/java/com/pokerogue/helper/biome/data/NativePokemon.java

backend/pokerogue/src/main/java/com/pokerogue/helper/biome/data/BiomePokemonType.java

backend/pokerogue/src/main/java/com/pokerogue/helper/biome/data/NextBiome.java

backend/pokerogue/src/main/java/com/pokerogue/helper/move/service/MoveService.java

backend/pokerogue/src/main/java/com/pokerogue/helper/biome/service/BiomeService.java

backend/pokerogue/src/main/java/com/pokerogue/helper/move/service/MoveService.java

…4-pokerogue-helper into be/refactor/#332-biome-move-mongo

jongmee

비토 고생하셨습니다!! 리뷰 아주 조금 달았어요 ㅎㅎ..

jongmee · 2024-09-26T11:29:07Z

backend/pokerogue/src/main/java/com/pokerogue/helper/biome/data/NativePokemon.java

 public class NativePokemon {

-    private final String tier; // Todo: enum 사용
-    private final List<String> pokemonIds;
+    private static final String BOSS = "보스";


여기 밑에 개행이 빠진 것 같아요!

수정했습니다! ☺️☺️

backend/pokerogue/src/main/java/com/pokerogue/helper/biome/service/BiomeService.java

backend/pokerogue/src/main/java/com/pokerogue/helper/move/service/MoveService.java

jongmee · 2024-09-26T11:39:16Z

/noti 비토! 리뷰 달았어요 ☺️ 노티 기능 정말 편하네..

unifolio0 · 2024-09-26T12:04:35Z

/noti

미아랑 폴라 리뷰 반영 완료

jongmee

어프룹! 🎉

dwax1324 · 2024-09-27T00:16:32Z

backend/pokerogue/src/main/java/com/pokerogue/helper/move/service/MoveService.java

+        List<Pokemon> pokemons = pokemonRepository.findByPokedexNumber(pokedexNumber);
+        return makeMoveResponse(pokemons.get(0));


없는 도감번호라면 예외가 발생할거 같아요🪶
리턴전에 개행!

수정했습니다! ☺️☺️

dwax1324 · 2024-09-27T00:19:11Z

backend/pokerogue/src/main/java/com/pokerogue/helper/pokemon/dto/PokemonDetailResponse.java

-        List<MoveResponse> moves,
-        List<MoveResponse> eggMoveResponses,
+        List<PokemonMoveResponse> moves,
+        List<PokemonMoveResponse> eggPokemonMoveRespons,


수정했습니다! ☺️☺️

dwax1324 · 2024-09-27T00:23:37Z

비토 고생하셨습니다🦎
이미 리펙터링이 많이 진행된거 같아서 짧게 남겨요

jinchiim

Approve 했습니다!

unifolio0 added 10 commits September 25, 2024 09:56

refactor: Biome MongoDB를 사용하도록 리팩토링

c617f66

refactor: Move MongoDB를 사용하도록 리팩토링

8461dba

refactor: Biome 관련 사용하지 않는 클래스 삭제

d46830f

refactor: 테스트 통과하도록 수정

3cfeae4

refactor: 로그 추가

958915d

test: 테스트 작성

4e644e1

refactor: 불필요한 필드 및 메소드 삭제

db2053c

refactor: 일단 테스트 삭제

40b1803

refactor: 일단 테스트

305c4d3

refactor: 테스트 통과하도록 수정

b3a91dc

unifolio0 requested review from jongmee, jinchiim and dwax1324 September 25, 2024 11:22

unifolio0 self-assigned this Sep 25, 2024

unifolio0 added the BE_REFACTOR 🌿 백엔드 리팩토링 label Sep 25, 2024

unifolio0 added this to the BE 포켓로그 1차 배포 milestone Sep 25, 2024

jongmee requested changes Sep 25, 2024

View reviewed changes

refactor: getter 삭제

6e9e8f5

jinchiim requested changes Sep 26, 2024

View reviewed changes

unifolio0 added 10 commits September 26, 2024 18:39

refactor: BiomePokemonType 삭제

d1f3456

refactor: 상수화

df2e8a7

refactor: 메시지 수정

346a2f6

refactor: AllArgsConstructor 삭제

9588078

refactor: 메소드명 수정

24f4738

refactor: 로그에 스레드 정보 포함

e188470

refactor: 반환값 확인

82d4bef

refactor: 메소드 순서 변경

b311da2

refactor: 캐싱 삭제

9479e9d

Merge branch 'be/develop' of https://github.com/woowacourse-teams/202…

653d516

…4-pokerogue-helper into be/refactor/#332-biome-move-mongo

unifolio0 added 5 commits September 26, 2024 19:33

refactor: 캐싱 삭제

08bf2c2

refactor: 테스트 복구

e8b2876

refactor: notExistMove 테스트 작성

e6a433c

refactor: notExistBiome 테스트 작성

b1619a0

refactor: ErrorMessage 수정

c52c55c

unifolio0 force-pushed the be/refactor/#332-biome-move-mongo branch from 787902d to c52c55c Compare September 26, 2024 11:21

jongmee requested changes Sep 26, 2024

View reviewed changes

unifolio0 added 2 commits September 26, 2024 20:43

refactor: 개행 추가

83909de

refactor: findAllById 적용

469e8d9

jongmee approved these changes Sep 26, 2024

View reviewed changes

refactor: 테스트 깨지는 오류 수정

46f5ad9

dwax1324 approved these changes Sep 27, 2024

View reviewed changes

unifolio0 added 4 commits September 27, 2024 10:25

refactor: 오타 수정

2c069be

refactor: 에러 처리

f4fe902

refactor: Backend-CI.yml 수정

9721101

refactor: Backend-CI.yml 수정

93736f3

jinchiim approved these changes Sep 27, 2024

View reviewed changes

unifolio0 added 3 commits September 27, 2024 11:24

refactor: conflict 해결

450c4b1

refactor: conflict로 인한 오류 해결

fa15573

refactor: 중복 클래스 삭제

c1f6973

unifolio0 merged commit 9b9aca7 into be/develop Sep 27, 2024
1 check passed

unifolio0 deleted the be/refactor/#332-biome-move-mongo branch September 27, 2024 02:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BE-REFACTOR] Biome, Move 정보 MongoDB 사용하도록 리팩토링 #335

[BE-REFACTOR] Biome, Move 정보 MongoDB 사용하도록 리팩토링 #335

unifolio0 commented Sep 25, 2024

unifolio0 commented Sep 25, 2024

jongmee left a comment

jinchiim left a comment

jongmee left a comment •

edited

Loading

jongmee Sep 26, 2024

unifolio0 Sep 26, 2024

jongmee commented Sep 26, 2024

unifolio0 commented Sep 26, 2024

jongmee left a comment •

edited

Loading

dwax1324 Sep 27, 2024

unifolio0 Sep 27, 2024

dwax1324 Sep 27, 2024

unifolio0 Sep 27, 2024

dwax1324 commented Sep 27, 2024

jinchiim left a comment

		List<Pokemon> pokemons = pokemonRepository.findByPokedexNumber(pokedexNumber);
		return makeMoveResponse(pokemons.get(0));

[BE-REFACTOR] Biome, Move 정보 MongoDB 사용하도록 리팩토링 #335

[BE-REFACTOR] Biome, Move 정보 MongoDB 사용하도록 리팩토링 #335

Conversation

unifolio0 commented Sep 25, 2024

🍄 PR 확인 사항

현재 작업은 어떤 이슈를 해결한 것인지 설명해주세요.

기존 코드에서 변경된 점이 있다면 설명해주세요. (추가 X)

unifolio0 commented Sep 25, 2024

jongmee left a comment

Choose a reason for hiding this comment

jinchiim left a comment

Choose a reason for hiding this comment

jongmee left a comment • edited Loading

Choose a reason for hiding this comment

jongmee Sep 26, 2024

Choose a reason for hiding this comment

unifolio0 Sep 26, 2024

Choose a reason for hiding this comment

jongmee commented Sep 26, 2024

unifolio0 commented Sep 26, 2024

jongmee left a comment • edited Loading

Choose a reason for hiding this comment

dwax1324 Sep 27, 2024

Choose a reason for hiding this comment

unifolio0 Sep 27, 2024

Choose a reason for hiding this comment

dwax1324 Sep 27, 2024

Choose a reason for hiding this comment

unifolio0 Sep 27, 2024

Choose a reason for hiding this comment

dwax1324 commented Sep 27, 2024

jinchiim left a comment

Choose a reason for hiding this comment

jongmee left a comment •

edited

Loading

jongmee left a comment •

edited

Loading