Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1.0/AN_REFACTOR] APP 단의 FIrebase 초기화 코드 analytics 모듈로 이동 #318

Merged
merged 1 commit into from
Sep 15, 2024
Merged

[1.1.0/AN_REFACTOR] APP 단의 FIrebase 초기화 코드 analytics 모듈로 이동 #318

merged 1 commit into from
Sep 15, 2024

Conversation

murjune
Copy link
Contributor

@murjune murjune commented Sep 10, 2024 •
edited
Loading

작업한 내용

  • Build Variant 에 따라 AnalyticsLogger 설정해주는 코드를 :analytics 모듈로 옮겼습니다~

@github-actions github-actions bot added the AN_REFACTOR ✍️ 안드로이드 리팩토링 label Sep 10, 2024
sh1mj1
sh1mj1 approved these changes Sep 10, 2024
View reviewed changes
Copy link

@sh1mj1 sh1mj1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋ 이거 오둥이가 했군요 확인 ~

kkosang
kkosang approved these changes Sep 10, 2024
View reviewed changes
Copy link

@kkosang kkosang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿입니다 5둥2준1 ~~ 👍

JoYehyun99
JoYehyun99 approved these changes Sep 11, 2024
View reviewed changes
Copy link

@JoYehyun99 JoYehyun99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

귣귣~

@murjune murjune merged commit 1326b1a into an/develop Sep 15, 2024
2 checks passed
@murjune murjune deleted the refactor/analytics-code branch September 15, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoYehyun99 JoYehyun99 JoYehyun99 approved these changes

@kkosang kkosang kkosang approved these changes

@sh1mj1 sh1mj1 sh1mj1 approved these changes

Assignees

@murjune murjune

Labels
AN_REFACTOR ✍️ 안드로이드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murjune @JoYehyun99 @kkosang @sh1mj1