-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.1.0/AN-FEAT] 배틀 선택 / 결과 UI 개선 #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
잘봤습니다!!!
고생 많았어요!~ 👍👍👍👍
power = power.toString(), | ||
fun BattlePrediction.toUi(format: String = DEFAULT_NUMBER_FORMAT): BattlePredictionUiModel { | ||
val formattedPower = if (power < 0) NO_EFFECT_VALUE else power.toString() | ||
val formattedResult = if (calculatedResult < 0) NO_EFFECT_VALUE else String.format(format, calculatedResult) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이러한 상황일 때 추가로 배수도 - 로 표시하는 게 더 자연스러워 보입니다.
저는 배수는 1.0으로 보여주는 것도 좋아요 !
3개 다 - - - 로 보여주면 뭔가 어색할 것 같기도 해요
명중 확률
이 부분은 동의합니다 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저두요
@@ -80,7 +80,12 @@ class SkillSelectionFragment : | |||
|
|||
repeatOnStarted { | |||
viewModel.filteredSkills.collect { | |||
skillAdapter.submitList(it) | |||
skillAdapter.submitList(it) { | |||
if (viewModel.previousSkillsId != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viewModel.previousSkillsId
이제 봤는데 이전 스킬 id 가 이전 스킬들 id 로 되어 있네요 ㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그러게 ㅋㅋㅋㅋ
if (sharedViewModel.previousSelection.selectedPokemon() != null) { | ||
val position = it.indexOfFirst { it.isSelected } | ||
binding.rvPokemons.scrollToPosition(position) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 섬세한데요~
submitList 에 람다로 바로 콜백을 지정할 수 있군요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헐 대박.. 제 코드 수정하러 갑니다 ㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 이게 되네 ㅋㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
조대리님 굿입니다 👍~~
power = power.toString(), | ||
fun BattlePrediction.toUi(format: String = DEFAULT_NUMBER_FORMAT): BattlePredictionUiModel { | ||
val formattedPower = if (power < 0) NO_EFFECT_VALUE else power.toString() | ||
val formattedResult = if (calculatedResult < 0) NO_EFFECT_VALUE else String.format(format, calculatedResult) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이러한 상황일 때 추가로 배수도 - 로 표시하는 게 더 자연스러워 보입니다.
저는 배수는 1.0으로 보여주는 것도 좋아요 !
3개 다 - - - 로 보여주면 뭔가 어색할 것 같기도 해요
명중 확률
이 부분은 동의합니다 !
if (sharedViewModel.previousSelection.selectedPokemon() != null) { | ||
val position = it.indexOfFirst { it.isSelected } | ||
binding.rvPokemons.scrollToPosition(position) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헐 대박.. 제 코드 수정하러 갑니다 ㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~
power = power.toString(), | ||
fun BattlePrediction.toUi(format: String = DEFAULT_NUMBER_FORMAT): BattlePredictionUiModel { | ||
val formattedPower = if (power < 0) NO_EFFECT_VALUE else power.toString() | ||
val formattedResult = if (calculatedResult < 0) NO_EFFECT_VALUE else String.format(format, calculatedResult) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저두요
if (sharedViewModel.previousSelection.selectedPokemon() != null) { | ||
val position = it.indexOfFirst { it.isSelected } | ||
binding.rvPokemons.scrollToPosition(position) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 이게 되네 ㅋㅋㅋ
@@ -80,7 +80,12 @@ class SkillSelectionFragment : | |||
|
|||
repeatOnStarted { | |||
viewModel.filteredSkills.collect { | |||
skillAdapter.submitList(it) | |||
skillAdapter.submitList(it) { | |||
if (viewModel.previousSkillsId != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그러게 ㅋㅋㅋㅋ
/noti |
-> 작업 단위가 작아서 두 개 이슈 합침 이슈
작업 영상
XRecorder_Edited_10092024_140105.mp4
작업한 내용
-
로 표시distinct
로 방지해두었습니당🚀Next Feature