Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE-INFRA] 개발 DB 서버 설정 #347

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

jongmee
Copy link
Contributor

@jongmee jongmee commented Sep 26, 2024

🍄 PR 확인 사항

PR이 다음 요구 사항을 충족하는지 확인하세요. :

  • API 명세서가 업데이트 혹은 작성이 되어 있나요?

현재 작업은 어떤 이슈를 해결한 것인지 설명해주세요.

Issue Number: #346

  • 개발용 MongoDB ec2 instance 세팅
  • 개발 서버 profile 설정

기존 코드에서 변경된 점이 있다면 설명해주세요. (추가 X)

  • 있음
  • 없음

이 PR 역시 다른 PR들보다 먼저 머지된다면 다른 PR이 개발 서버에 배포 돼도 오류 없이 MongoDB에 연결돼서 작동할 수 있습니다 🙂

@jongmee jongmee added the BE_INFRA 🚧 백엔드 인프라 label Sep 26, 2024
@jongmee jongmee self-assigned this Sep 26, 2024
@jongmee
Copy link
Contributor Author

jongmee commented Sep 26, 2024

추가된 변경 사항

  • prod 서버가 두 개이므로 안전하게 러너 태그를 재설정했습니다.
  • 현재 사용하는 서버는 추후 서브넷 a에 해당합니다.

Copy link
Contributor

@jinchiim jinchiim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! LGTM!
질문 하나만 달았는데 확인해주세요! 😄

@@ -66,5 +66,5 @@ jobs:
docker run -d -p 8080:8080 --name server \
-e JAVA_OPTS="-XX:InitialRAMPercentage=70.0 -XX:MaxRAMPercentage=70.0" \
-e TZ=Asia/Seoul \
-e SPRING_PROFILES_ACTIVE=local \
-e SPRING_PROFILES_ACTIVE=dev \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

드디어 개발 환경을 사용해보는 군요 😋

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제대로 된 개발 환경 냠냠

@@ -17,7 +17,7 @@ jobs:

build:
needs: test
runs-on: cd
runs-on: [cd, app-a]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

서브넷을 뜻하는 a 일까요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 맞습니다! 우테코에서 제공해준 서브넷 이름이 app-a 더라고요!

이 pr에 포함시켜야 하나 헷갈렸는데 현재 cd tag를 가진 runner가 두 개여서 (app-b를 생성함) 안전하게 설정해뒀습니다 ☺️

@jongmee
Copy link
Contributor Author

jongmee commented Sep 26, 2024

/noti @폴라 코멘트 달아뒀어요!

Copy link

@unifolio0 unifolio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

데황 미아

@jongmee jongmee changed the title [BE-INFRA] 개발 DB 서버 설정 [BE-INFRA] 운영, 개발 DB 서버 설정 Sep 26, 2024
@jongmee jongmee changed the title [BE-INFRA] 운영, 개발 DB 서버 설정 [BE-INFRA] 개발 DB 서버 설정 Sep 26, 2024
@jongmee jongmee merged commit 6d5e8e0 into be/develop Sep 26, 2024
1 check passed
@jongmee jongmee deleted the be/infra/#346-set-dev-mongo-db branch September 26, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE_INFRA 🚧 백엔드 인프라
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants