refactor: App -> analytics 모듈로 FIrebase init 로직 이동

woowacourse-teams · Sep 10, 2024 · 29ee1b1 · 29ee1b1
1 parent 9b80faa
commit 29ee1b1
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 36 deletions.
diff --git a/android/analytics/src/main/java/poke/rogue/helper/analytics/AnalyticsInitializer.kt b/android/analytics/src/main/java/poke/rogue/helper/analytics/AnalyticsInitializer.kt
@@ -0,0 +1,28 @@
+package poke.rogue.helper.analytics
+
+import com.google.firebase.analytics.ktx.analytics
+import com.google.firebase.crashlytics.ktx.crashlytics
+import com.google.firebase.ktx.Firebase
+
+object AnalyticsInitializer {
+    fun init() {
+        when (BuildConfig.BUILD_TYPE) {
+            DEBUG_MODE -> {
+                Firebase.analytics.setAnalyticsCollectionEnabled(false)
+                Firebase.crashlytics.setCrashlyticsCollectionEnabled(false)
+            }
+
+            ALPHA_MODE -> {
+                Firebase.analytics.setAnalyticsCollectionEnabled(false)
+                Firebase.crashlytics.setCrashlyticsCollectionEnabled(true)
+            }
+
+            BETA_MODE, RELEASE_MODE -> {
+                Firebase.analytics.setAnalyticsCollectionEnabled(true)
+                Firebase.crashlytics.setCrashlyticsCollectionEnabled(true)
+            }
+
+            else -> error("Unknown build type")
+        }
+    }
+}
diff --git a/android/analytics/src/main/java/poke/rogue/helper/analytics/AnalyticsLogger.kt b/android/analytics/src/main/java/poke/rogue/helper/analytics/AnalyticsLogger.kt
@@ -1,9 +1,9 @@
 package poke.rogue.helper.analytics
 
-private const val DEBUG_MODE = "debug"
-private const val ALPHA_MODE = "alpha"
-private const val BETA_MODE = "beta"
-private const val RELEASE_MODE = "release"
+internal const val DEBUG_MODE = "debug"
+internal const val ALPHA_MODE = "alpha"
+internal const val BETA_MODE = "beta"
+internal const val RELEASE_MODE = "release"
 
 /** Analytics API surface */
 interface AnalyticsLogger {

diff --git a/android/app/src/main/java/poke/rogue/helper/PokeRogueHelperApp.kt b/android/app/src/main/java/poke/rogue/helper/PokeRogueHelperApp.kt
@@ -1,17 +1,15 @@
 package poke.rogue.helper
 
 import android.app.Application
-import com.google.firebase.analytics.ktx.analytics
-import com.google.firebase.crashlytics.ktx.crashlytics
-import com.google.firebase.ktx.Firebase
+import poke.rogue.helper.analytics.AnalyticsInitializer
 import poke.rogue.helper.data.repository.DefaultDexRepository
 import timber.log.Timber
 
 class PokeRogueHelperApp : Application() {
     override fun onCreate() {
         super.onCreate()
         initTimber()
-        initFirebase()
+        AnalyticsInitializer.init()
         DefaultDexRepository.init(this)
     }
 
@@ -26,32 +24,4 @@ class PokeRogueHelperApp : Application() {
             )
         }
     }
-
-    private fun initFirebase() {
-        when (BuildConfig.BUILD_TYPE) {
-            DEBUG_MODE -> {
-                Firebase.analytics.setAnalyticsCollectionEnabled(false)
-                Firebase.crashlytics.setCrashlyticsCollectionEnabled(false)
-            }
-
-            ALPHA_MODE -> {
-                Firebase.analytics.setAnalyticsCollectionEnabled(false)
-                Firebase.crashlytics.setCrashlyticsCollectionEnabled(true)
-            }
-
-            BETA_MODE, RELEASE_MODE -> {
-                Firebase.analytics.setAnalyticsCollectionEnabled(true)
-                Firebase.crashlytics.setCrashlyticsCollectionEnabled(true)
-            }
-
-            else -> error("Unknown build type")
-        }
-    }
-
-    companion object {
-        private const val DEBUG_MODE = "debug"
-        private const val ALPHA_MODE = "alpha"
-        private const val BETA_MODE = "beta"
-        private const val RELEASE_MODE = "release"
-    }
 }