-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[BE 이연호] 1주차 과제 제출합니다. #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Timothy-Y-H-Lee
wants to merge
14
commits into
woowacourse-precourse:main
Choose a base branch
from
Timothy-Y-H-Lee:Timothy-Y-H-Lee
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[BE 이연호] 1주차 과제 제출합니다. #1111
Timothy-Y-H-Lee
wants to merge
14
commits into
woowacourse-precourse:main
from
Timothy-Y-H-Lee:Timothy-Y-H-Lee
+368
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alysis # 프로젝트의 기능 요구사항 및 기능 목록 초안 작성 (문제 핵심 파악 포함)
# feat(#1): MVC & TDD - Store user input in the model - Model: 사용자의 입력값을 생성자를 통해서 저장 # Model: Save user input via constructor - ModelTest: 사용자의 입력값을 기본 구분자(",:")로 분리 후 모델에 저장한 뒤, 이를 꺼냈을 때 값이 동일한지 테스트 # ModelTest: Split user input using default delimiters (",:"); # store it in the model and verify retrieved values match the original
# 기능목록 업데이트 - MVC & TDD - use Service to save user input into the Model # MVC & TDD - Service를 이용해서 모델에 사용자의 입력값을 저장
# feat(#2): Use Service to store user input into the model - 싱글톤을 이용해서, 입력값인 문자열에 기본 구분자들(쉼표(,)와 콜론(:))이 포함되어 있는지 체크 # Using a singleton, check if the input string contains the default delimiters (comma ',' and colon ':')
# feat(#2): Use Service to store user input into the model - 싱글톤을 이용해서, 입력값인 문자열에 "//"와 "\n" 사이의 커스텀 구분자가 있는지 체크 # Using a singleton, check if the input string contains a custom delimiter between "//" and "\n"
# docs(#2): update feature list - 서비스, 컨트롤러, 뷰의 기능목록을 업데이트 # Updated the feature list of Service, Controller, and View
# refactor(#2): move CalculatorService to a new package location - 변경된 패키지 위치: calculator.service.CalculatorService # Updated package location: calculator.service.CalculatorService
# feat(#2): complete MVC structure - 나머지 MVC 구조 제작 후, "커스텀_구분자_사용" 테스트 케이스 통과 # After completing the remaining MVC components, the "custom_delimiter_usage" test case passed
# docs(#2): update feature list – add test case to ensure only positive input values are accepted - 기능 목록 추가 사항: "입력값이 양수만 입력이 가능하도록 테스트 케이스 처리" # Added feature list item: test case ensuring only positive numbers can be entered
# feat(#2): handle test case to allow only positive input values - "예외_테스트()" 테스트 케이스를 통해, 입력값이 양수만 입력이 가능하도록 테스트 케이스 처리 # Through the "exception_test()" test case, ensure that only positive input values are allowed
…스 처리 # docs(#2): update feature list - add test case allowing both default and custom delimiters in user input - 기능목록 업데이트: 사용자의 입력값에서 기본 구분자와 커스텀 구분자를 함께 사용이 가능하도록 테스트 케이스 처리 # Updated feature list: test case ensuring both default and custom delimiters can be used together in user input
# feat(#2): add test case to allow both default and custom delimiters in user input - As-Is: 기존에는 사용자의 입력값 중에 커스텀 구분자와 기본 구분자를 함께 사용할 수 없었음. # As-Is: User input could not contain both custom and default delimiters. - To-Be: 사용자의 입력값에서 기본 구분자와 커스텀 구분자를 함께 사용이 가능하도록 테스트 케이스 처리 # To-Be: Added a test case to ensure that user input supports both default and custom delimiters.
# docs(#2): update feature list – actually use Model to store and retrieve a list of numbers separated by delimiters - 사용자의 입력값을 Model을 사용해서 구분자로 정리된 숫자 목록을 저장 후, 꺼내어 사용 # Used the Model to store the list of numbers separated by delimiters and retrieve them when needed
# feat(#2): actually use Model to store and retrieve a list of numbers separated by delimiters - As-Is: 기존에는 사용자의 입력값을 모델에 저장하지 않음. # As-Is: The user input was not stored in the model. - To-Be: 사용자의 입력값을 Model을 사용해서 구분자로 정리된 숫자 목록을 저장 후, 꺼내어 사용 # To-Be: Use the Model to store the list of numbers separated by delimiters and retrieve them when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1주차 과제: 구분자로 자른 문자열의 숫자값 덧셈