Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] store 도메인의 isOpen 메서드 수정 못했던것 수정 #122

Conversation

Hyeon-Uk
Copy link
Contributor

@Hyeon-Uk Hyeon-Uk commented Aug 20, 2024

이전 PR에서 storeTime의 구조를 변경하면서 미처 변경하지 못한 도메인 수정

💡 다음 이슈를 해결했어요.

Issue Link - #84


✅ 셀프 체크리스트

  • 내 코드를 스스로 검토했습니다.
  • 필요한 테스트를 추가했습니다.
  • 모든 테스트를 통과합니다.
  • 브랜치 전략에 맞는 브랜치에 PR을 올리고 있습니다.
  • 커밋 메세지를 컨벤션에 맞추었습니다.
  • wiki를 수정했습니다.

이전 PR에서 storeTime의 구조를 변경하면서 미처 변경하지 못한 도메인 수정
@Hyeon-Uk Hyeon-Uk added the 🐞 BugFix Something isn't working label Aug 20, 2024
@Hyeon-Uk Hyeon-Uk self-assigned this Aug 20, 2024
Copy link
Member

@kimhyun5u kimhyun5u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hyeon-Uk Hyeon-Uk merged commit 0333cd9 into main Aug 21, 2024
1 check passed
@kimhyun5u kimhyun5u deleted the fix/84_Hyeon-Uk_store_도메인에_추가한_isOpen_메서드_오류_사항_발견_다시_수정 branch August 22, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 BugFix Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants