Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 점주는 페이지별 주문 리스트를 조회할 수 있다 #115

Merged
merged 8 commits into from
Aug 20, 2024
Merged

[feat] 점주는 페이지별 주문 리스트를 조회할 수 있다 #115

merged 8 commits into from
Aug 20, 2024

Conversation

Dr-KoKo
Copy link
Member

@Dr-KoKo Dr-KoKo commented Aug 19, 2024 •
edited
Loading

💡 다음 이슈를 해결했어요.

Issue Link - #113

  • 점주가 조회하는 주문 리스트에 페이지네이션 구현

💡 이슈를 처리하면서 추가된 코드가 있어요.

  • OrderRepository의 findAllByOwner()/findByStore() 는 이제 deprecate
  • OrderApiController의 [GET] /orders, [GET] /orders/stores/{storeId}의 응답 타입이 Page로 변경

💡 이런 고민을 했어요.


✅ 셀프 체크리스트

  • 내 코드를 스스로 검토했습니다.
  • 필요한 테스트를 추가했습니다.
  • 모든 테스트를 통과합니다.
  • 브랜치 전략에 맞는 브랜치에 PR을 올리고 있습니다.
  • 커밋 메세지를 컨벤션에 맞추었습니다.
  • wiki를 수정했습니다.

@Dr-KoKo Dr-KoKo added the ✨ Feature 기능 개발 label Aug 19, 2024
@Dr-KoKo Dr-KoKo self-assigned this Aug 19, 2024
@Dr-KoKo Dr-KoKo linked an issue Aug 19, 2024 that may be closed by this pull request
[기능] 점주는 페이지별 주문 리스트를 조회할 수 있다. #113
Closed
@Dr-KoKo
[fix] deprecate OrderRepository.findByStore, OrderRepository.findAllB…
1822a23 
…yOwner

필터링 기능을 구현하면서 위 메서드는 삭제될 예정입니다.
@Dr-KoKo
[fix] deprecate OrderRepository.findAllByStore_Owner_Id, OrderReposit…
c113b57 
…ory.findByStore_Id

필터링 기능을 구현하면서 위 메서드는 삭제될 예정입니다.
@Dr-KoKo Dr-KoKo marked this pull request as ready for review August 19, 2024 14:37
kimhyun5u
kimhyun5u approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@kimhyun5u kimhyun5u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 일단 JPA 페이지네이션으로 구현해놓은거죠 ?

june-777
june-777 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@june-777 june-777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인완료입니다!

Hyeon-Uk
Hyeon-Uk approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@Hyeon-Uk Hyeon-Uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 완료했습니다!

@Dr-KoKo Dr-KoKo merged commit 718f7a3 into main Aug 20, 2024
1 check passed
@kimhyun5u kimhyun5u deleted the feature/113_Dr-KoKo_점주는_페이지별_주문_리스트를_조회할_수_있다 branch August 22, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@june-777 june-777 june-777 approved these changes

@Hyeon-Uk Hyeon-Uk Hyeon-Uk approved these changes

@kimhyun5u kimhyun5u kimhyun5u approved these changes

Assignees

@Dr-KoKo Dr-KoKo

Labels
✨ Feature 기능 개발
Projects
3K1K Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[기능] 점주는 페이지별 주문 리스트를 조회할 수 있다.
4 participants
@Dr-KoKo @kimhyun5u @Hyeon-Uk @june-777