Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Cash App Pay works as expected on mobile device. #290

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Feb 19, 2025

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

As mentioned here, Cash App Pay is not working after redirecting back to the store in WooCommerce 9.7 RC-1. This PR improves how the payment method is selected after the redirect from the Cash App and fixes the issue to ensure it works as expected.

Steps to test the changes in this Pull Request:

  1. Update to WooCommerce 9.7 RC-1
  2. Set up Cash app Pay and verify that it works fine on mobile devices and desktop browsers.
  3. Downgrate WooCommerce to the minimum supported version.
  4. Verify that Cash app pay works fine on mobile devices and desktop browsers.

Changelog entry

Fix - Ensure that Cash App Pay works as expected on mobile devices.

@iamdharmesh iamdharmesh self-assigned this Feb 19, 2025
@iamdharmesh iamdharmesh changed the title [WIP] Ensure that Cash App Pay works as expected on mobile device. Ensure that Cash App Pay works as expected on mobile device. Feb 19, 2025
@iamdharmesh iamdharmesh added this to the Future Release milestone Feb 19, 2025
@iamdharmesh iamdharmesh requested a review from dkotter February 19, 2025 17:03
@iamdharmesh iamdharmesh mentioned this pull request Feb 19, 2025
@iamdharmesh iamdharmesh modified the milestones: Future Release, 4.8.7 Feb 19, 2025
@dkotter dkotter added the needs: UAT The Issue/PR needs to go through UAT label Feb 19, 2025
@dkotter
Copy link
Contributor

dkotter commented Feb 19, 2025

This can go to UAT once QA passes

@qasumitbagthariya
Copy link
Contributor

QA Update: ✅


I have verified this PR in the fix/cash-app-pay-mobile branch which has been fixed and is functioning as intended.

I tested the following on this branch:

  • I have tested the Cash App functionality on both desktop and mobile devices using WooCommerce versions 9.7 RC-1 and 9.6.2.

Desktop

Screen.Recording.2025-02-20.at.3.14.37.PM.mov

Mobile

ScreenRecording_02-20-2025.15-22-32_1.mov

Testing Environment

  • WordPress: 6.7.2
  • Theme: Twenty Twenty-Four 1.3
  • WooCommerce - 9.7 RC-1 / 9.6.2
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS 15.2
  • Branch: fix/cash-app-pay-mobile

Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for UAT
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:

  • Yes
  • Not Required/Applicable for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: UAT The Issue/PR needs to go through UAT status: e2e tests passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants