-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add digit handling for country-specific currencies #288
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some formatting issues here that need cleaned up, likely a tabs vs spaces thing
Replaced spaces with tabs. Please review when you have a moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some additional lint errors that need cleaned up. See https://github.com/woocommerce/woocommerce-square/actions/runs/13407493861/job/37497707380?pr=288
I have fixed the code to resolve the lint errors. Please review it again. |
@qasumitbagthariya Thank you for checking. The error doesn't occur with 100 yen because it's divisible by 100. Please try making a payment with an amount that isn't divisible by 100, such as 90 yen or 150 yen. Since these would contain decimal points when processed, Square should reject these transactions. |
All Submissions:
Changes proposed in this Pull Request:
This pull request adds digit handling for country-specific currencies, addressing an issue with Japanese Yen (JPY) credit card transactions. It ensures correct handling for currencies that do not require division by 100.
Closes # .
Steps to test the changes in this Pull Request:
Changelog entry
Add - Digit handling for country-specific currencies to prevent incorrect division by 100 for currencies like Japanese Yen.