Skip to content

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Nov 4, 2025

Part of: WOOMOB-1335

Merge after: #16309

Description

This PR stores a site-specifc setting for syncing the catalog over cellular.

The toggle previously existed, but didn't do anything. It still doesn't do anything... but we remember the setting now!

A following PR will include the use of the setting for our network requests.

Test Steps

  1. Open POS for a store which is eligible for local catalog.
  2. Go to POS settings > Catalog
  3. Observe that the toggle starts out on
  4. Turn it off
  5. Switch stores and repeat – observe it is on for the new store
  6. Go back to the first store – observe it's still off for that store
  7. Force quit and reopen the app – observe the settings are still as you left them.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added this to the 23.7 milestone Nov 4, 2025
@joshheald joshheald added type: task An internally driven task. feature: POS labels Nov 4, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 4, 2025

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@joshheald joshheald force-pushed the woomob-1335-woo-poslocal-catalog-perform-full-sync-on-cellular-data branch from 7660766 to 29fc16b Compare November 4, 2025 17:43
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16314-29fc16b
Version23.6
Bundle IDcom.automattic.alpha.woocommerce
Commit29fc16b
Installation URL7j2ecdajciot8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma self-assigned this Nov 5, 2025
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still doesn't do anything... but we remember the setting now!

🎉🎉 🎉 🎉

LGTM 🚢

Base automatically changed from woomob-1111-woo-poslocal-catalog-add-catalog-needs-refreshing-warning to trunk November 5, 2025 08:17
@joshheald joshheald merged commit 9ce35ff into trunk Nov 5, 2025
16 checks passed
@joshheald joshheald deleted the woomob-1335-woo-poslocal-catalog-perform-full-sync-on-cellular-data branch November 5, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants