Skip to content

Conversation

@adborbas
Copy link
Contributor

@adborbas adborbas commented Nov 3, 2025

Closes: WOOMOB-1618

Description

Adds coloring to the booking status. Currently, only the No-show and Unpaid are colored, but we can easily extend this if needed.

Test Steps

  1. Log in to a CIAB store that has various bookings.
  2. Validate that No-show and Unpaid are color "yellowish".
  3. Validate that the same coloring is applied to the bookings detils.

Screenshots

Booking list Booking detail
Screenshot 2025-11-03 at 12 25 06 Screenshot 2025-11-03 at 12 25 32

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@adborbas adborbas force-pushed the adborbas/woomob-1236 branch from 03a0ae7 to a56c570 Compare November 3, 2025 08:59
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 3, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16307-620f937
Version23.6
Bundle IDcom.automattic.alpha.woocommerce
Commit620f937
Installation URL1l40vbocspsqg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@adborbas adborbas marked this pull request as ready for review November 3, 2025 12:32
@adborbas adborbas changed the title Adborbas/woomob 1236 [Booking] Update booking badges colours Nov 3, 2025
@itsmeichigo itsmeichigo self-assigned this Nov 4, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected. I left some suggestions in the comments.

Comment on lines 109 to 113
.overlay(
Circle()
.stroke(Color.white, lineWidth: Layout.borderLineWidth)
.opacity(customizations.bordered ? 1 : 0)
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: why don't we apply this only if bordered is true?

Suggested change
.overlay(
Circle()
.stroke(Color.white, lineWidth: Layout.borderLineWidth)
.opacity(customizations.bordered ? 1 : 0)
)
.if(customizations.bordered) { view in
view.overlay(
Circle()
.stroke(Color.white, lineWidth: Layout.borderLineWidth)
)
}

Similar suggestion for the case below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here

Comment on lines 15 to +16
"BookingAttendanceStatus.checkedIn",
value: "Checked In",
value: "Checked-in",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of manually updating the strings in Localizable.strings‎, you can update the key for the updated string. The new key and value will be generated automatically in Localizable.strings‎.

Suggested change
"BookingAttendanceStatus.checkedIn",
value: "Checked In",
value: "Checked-in",
"bookingAttendanceStatus.checkedIn.title",
value: "Checked-in",

Similar suggestion for the other change below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, but changing the key would mean that the intention of the text is different, but this is not the case now. Just the text is changing. In that sense, I'd keep the key and only change the value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I get your point, you might not need new translation for this text. I'm good with keeping this as-is.

@adborbas adborbas merged commit f64c8a1 into trunk Nov 4, 2025
14 checks passed
@adborbas adborbas deleted the adborbas/woomob-1236 branch November 4, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants