Skip to content

Conversation

@iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Oct 30, 2025

See AINFRA-1478

Description

This PR enhances the version validation added in the previous iteration to fail the build when there's a mismatch between the ReleasesV2 version and the project's computed version.

Previous behavior: Version mismatches showed a warning but allowed the build to continue.

New behavior: Version mismatches now fail the build with a clear error message, ensuring alignment between ReleasesV2 and the project before proceeding.

Changes

  • Changed version mismatch handling from warning to error
  • Build now fails with UI.user_error! when versions don't match
  • Updated Buildkite annotation from warning to error style

Testing

This will be tested in the next release cycle during code freeze.

@iangmaia iangmaia self-assigned this Oct 31, 2025
@iangmaia iangmaia added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Oct 31, 2025
@iangmaia iangmaia added this to the 23.7 milestone Oct 31, 2025
@iangmaia iangmaia force-pushed the iangmaia/fail-when-code-freeze-version-mismatch branch from 0f648e8 to 16ed476 Compare October 31, 2025 22:11
@iangmaia iangmaia marked this pull request as ready for review October 31, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants