Restore Wormholy, now installed via a fork supporting latest SPM #15771
Conversation
mokagio
added
the
category: tooling
|
|
mokagio
force-pushed
the
ainfra-606-try-the-wormholy-swiftpm-pr
branch
from
f25a1d5 to
8a2d783
Compare
There was a problem hiding this comment.
Thanks for adding it back, I can access the tool again! Tested in iPad simulator and device, the popover behavior is a bit off but still usable. I just had a question about if it's possible to exclude it in the release builds, but if it doesn't affect the build size / performance it's fine to include it.
| static let launchWormHolyDebug = NSLocalizedString( | ||
| "Launch Wormholy Debug", | ||
| comment: "Opens an internal library called Wormholy. Not visible to users." | ||
| ) |
There was a problem hiding this comment.
nit: we don't have to localize this string as this is developer-facing.
| @@ -65,6 +65,7 @@ let package = Package( | |||
| .package(url: "https://github.com/markiv/SwiftUI-Shimmer", from: "1.0.0"), | |||
| .package(url: "https://github.com/nalexn/ViewInspector", from: "0.10.0"), | |||
| .package(url: "https://github.com/onevcat/Kingfisher", from: "7.6.2"), | |||
| .package(url: "https://github.com/pmusolino/Wormholy", from: "2.0.0"), | |||
There was a problem hiding this comment.
Just wondering, can the package not get included in production builds in SPM? I tried building the app with the release build configuration and I still saw the related files being built. Not sure if the final build is optimized so that unused packages are removed, or this is just not supported in SPM.
There was a problem hiding this comment.
Unfortunately, Swift package manager does not support conditional compilation.
I know Apple does post processing of the IPA we send them, but I don't know if it removes unused frameworks.
There was a problem hiding this comment.
Unfortunately, Swift package manager does not support conditional compilation.
Actually, maybe I'm wrong, see https://developer.apple.com/documentation/packagedescription/buildsettingcondition
There was a problem hiding this comment.
Turns out I was right... Unfortunately.
SwiftPM allows conditional platform dependencies, but not conditional configurations.
See https://github.com/swiftlang/swift-evolution/blob/main/proposals/0273-swiftpm-conditional-target-dependencies.md which proposed both but is marked as implemented only for platform conditions.
It was possible at some point, but the capability was removed swiftlang/swift-package-manager#2598
mokagio
force-pushed
the
ainfra-606-try-the-wormholy-swiftpm-pr
branch
from
8a2d783 to
b67de20
Compare
Description
See removal PR #15668 and Wormholy PR pmusolino/Wormholy#154
https://linear.app/a8c/issue/AINFRA-606
Steps to reproduce & Testing information
Run on a device to verify it works
RELEASE-NOTES.txtif necessary.