Skip to content

[Tooling] Test fastlane trainer refactoring for Swift Testing support #15241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ gem 'cocoapods', '~> 1.14'
gem 'cocoapods-catalyst-support', '~> 0.1'
gem 'danger-dangermattic', '~> 1.2'
gem 'dotenv'
# 2.217.0 includes a fix for Xcode 15 test results parsing in CI
gem 'fastlane', '~> 2.217'
gem 'fastlane', '~> 2.227'
gem 'fastlane-plugin-appcenter', '~> 2.0'
gem 'fastlane-plugin-sentry', '~> 1.0'
# This comment avoids typing to switch to a development version for testing.
Expand Down
35 changes: 19 additions & 16 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,22 @@ GEM
artifactory (3.0.17)
ast (2.4.2)
atomos (0.1.3)
aws-eventstream (1.3.0)
aws-partitions (1.1029.0)
aws-sdk-core (3.214.1)
aws-eventstream (1.3.2)
aws-partitions (1.1065.0)
aws-sdk-core (3.220.1)
aws-eventstream (~> 1, >= 1.3.0)
aws-partitions (~> 1, >= 1.992.0)
aws-sigv4 (~> 1.9)
base64
jmespath (~> 1, >= 1.6.1)
aws-sdk-kms (1.96.0)
aws-sdk-core (~> 3, >= 3.210.0)
aws-sdk-kms (1.99.0)
aws-sdk-core (~> 3, >= 3.216.0)
aws-sigv4 (~> 1.5)
aws-sdk-s3 (1.176.1)
aws-sdk-core (~> 3, >= 3.210.0)
aws-sdk-s3 (1.182.0)
aws-sdk-core (~> 3, >= 3.216.0)
aws-sdk-kms (~> 1)
aws-sigv4 (~> 1.5)
aws-sigv4 (1.10.1)
aws-sigv4 (1.11.0)
aws-eventstream (~> 1, >= 1.0.2)
babosa (1.0.4)
base64 (0.2.0)
Expand Down Expand Up @@ -127,7 +128,7 @@ GEM
rubocop (~> 1.0)
declarative (0.0.20)
diffy (3.4.3)
digest-crc (0.6.5)
digest-crc (0.7.0)
rake (>= 12.0.0, < 14.0.0)
domain_name (0.6.20240107)
dotenv (2.8.1)
Expand Down Expand Up @@ -167,8 +168,8 @@ GEM
faraday-retry (1.0.3)
faraday_middleware (1.2.1)
faraday (~> 1.0)
fastimage (2.3.1)
fastlane (2.226.0)
fastimage (2.4.0)
fastlane (2.227.0)
CFPropertyList (>= 2.3, < 4.0.0)
addressable (>= 2.8, < 3.0.0)
artifactory (~> 3.0)
Expand Down Expand Up @@ -279,12 +280,13 @@ GEM
highline (2.0.3)
http-cookie (1.0.8)
domain_name (~> 0.5)
httpclient (2.8.3)
httpclient (2.9.0)
mutex_m
i18n (1.14.6)
concurrent-ruby (~> 1.0)
java-properties (0.3.0)
jmespath (1.6.2)
json (2.9.1)
json (2.10.1)
jwt (2.10.1)
base64
kramdown (2.5.1)
Expand All @@ -300,6 +302,7 @@ GEM
molinillo (0.8.0)
multi_json (1.15.0)
multipart-post (2.4.1)
mutex_m (0.3.0)
nanaimo (0.4.0)
nap (1.1.0)
naturally (2.2.1)
Expand Down Expand Up @@ -339,7 +342,7 @@ GEM
trailblazer-option (>= 0.1.1, < 0.2.0)
uber (< 0.2.0)
retriable (3.1.2)
rexml (3.4.0)
rexml (3.4.1)
rmagick (4.3.0)
rouge (3.28.0)
rubocop (1.68.0)
Expand All @@ -359,7 +362,7 @@ GEM
ruby-macho (2.5.1)
ruby-progressbar (1.13.0)
ruby2_keywords (0.0.5)
rubyzip (2.3.2)
rubyzip (2.4.1)
sawyer (0.9.2)
addressable (>= 2.3.5)
faraday (>= 0.17.3, < 3)
Expand Down Expand Up @@ -415,7 +418,7 @@ DEPENDENCIES
cocoapods-catalyst-support (~> 0.1)
danger-dangermattic (~> 1.2)
dotenv
fastlane (~> 2.217)
fastlane (~> 2.227)
fastlane-plugin-appcenter (~> 2.0)
fastlane-plugin-sentry (~> 1.0)
fastlane-plugin-wpmreleasetoolkit (~> 12.5)
Expand Down
2 changes: 1 addition & 1 deletion WooCommerce/WooCommerceTests/Model/AgeTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ final class AgeTests: XCTestCase {

let age = Age.from(startDate: dateFrom, toDate: dateTo, using: calendar)

XCTAssertEqual(age, .days)
XCTAssertEqual(age, .yesterday) // nope
}

func test_it_returns_days_if_the_dates_are_exactly_six_days_apart() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ struct CartViewHelperTests {
paymentState: .card(.validatingOrderError)) == false)
}

@Test(arguments: zip([0, 1, 2, 3], [nil, "1 item", "2 items", "3 items"]))
@Test(arguments: zip([0, 1, 2, 3], [nil, "1 item", "22 items", "3 items"]))
func itemsInCartLabel(_ count: Int, _ expected: String?) async throws {
// Given

Expand All @@ -82,7 +82,8 @@ struct CartViewHelperTests {
#expect(sut.shouldShowClearCartButton(cart: [makeItem()], orderStage: .building) == true)
}

@Test func shouldShowClearCartButton_items_in_cart_and_finalizing_false() async throws {
@Test(.disabled("Skip Skip Skip!"))
func shouldShowClearCartButton_items_in_cart_and_finalizing_false() async throws {
#expect(sut.shouldShowClearCartButton(cart: [makeItem()], orderStage: .finalizing) == false)
}
}
Expand Down
Loading