-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Stripe Express Checkout Elements (ECE) on the Product page #3441
Conversation
Full checklist I'm testing
Non-successful test cases
|
Hey Matt! I see the changelog.txt entry is missing 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, Matt!
- Change the quantity of the product, confirm the ECE button was blocked and unblocked
(tried to get a blocked image, but the loading is too fast)
- Confirm the order details and totals in Google Pay are correct
- Change shipping methods between free and flat rate and confirm price is correct
- Confirm the order is created in WooCommerce
- Confirm the charge in Stripe is correct
It does not work on my Android phone, but none of our previous implementations for this project does. We need to double check later.
Fixes #3410
Important
This PR is based off the changes in #3436. This branch will need to be updated to include any future changes made to that base branch.
Changes proposed in this Pull Request:
This PR implements Stripe's ECE (Google Pay & Apple Pay buttons) on the product page:
Testing instructions
There are A LOT scenarios to cover when testing these buttons from the product page. Let's start with the basics:
changelog.txt
andreadme.txt
(or does not apply)Post merge