Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow progress bar block to be added within Cart i2 block #27

Merged
merged 7 commits into from
Oct 25, 2021

Conversation

nielslange
Copy link
Member

@nielslange nielslange commented Oct 19, 2021

Fixes #25

Note

In the first iteration, a merchant should be able to use the shipping progress bar block within the Cart i2 block. This PR aims to enable merchants to do so.

Steps to test

  1. Check out this PR.
  2. Create a test page.
  3. Add the Cart i2 block.
  4. Add the Free Shipping Progress Bar block to the Cart Totals section.
  5. Ensure that the Free Shipping Progress Bar block is visible in the editor.
  6. Save the page and look up the frontend.
  7. Ensure that the Free Shipping Progress Bar block is visible in the frontend.
  8. Adjust the product quantity.
  9. Ensure that the progress bar changes based on the cart totals.

Screenshot

Editor:

27-editor

Frontend:

27-frontend

@nielslange nielslange requested a review from senadir October 20, 2021 00:16
@nielslange nielslange marked this pull request as ready for review October 21, 2021 05:00
Copy link
Member

@senadir senadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, except the extra code that should be deleted for now.

src/block.js Outdated Show resolved Hide resolved
src/block.js Outdated Show resolved Hide resolved
src/block.js Outdated Show resolved Hide resolved
@nielslange nielslange merged commit 317e52e into trunk Oct 25, 2021
@nielslange nielslange deleted the add/25-register-block-in-cart-i2 branch October 25, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register Block into Cart i2
2 participants