This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
January 23, 2023 11:27
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
gigitux
force-pushed
the
fix/flaky-e2e-tests
branch
4 times, most recently
from
January 24, 2023 09:05
a8e6e29
to
950dbb1
Compare
gigitux
added
skip-changelog
PRs that you don't want to appear in the changelog.
category: tests
labels
Jan 24, 2023
Remove this function when WP 6.2 is released.Remove this function when WP 6.2 is released. We can use the "switchBlockInspectorTab" function directly.
woocommerce-blocks/tests/utils/switch-block-inspector-tab-when-gutenberg-is-installed.ts Lines 11 to 19 in d3344c4
🚀 This comment was generated by the automations bot based on a
|
gigitux
force-pushed
the
fix/flaky-e2e-tests
branch
from
January 24, 2023 09:42
d3344c4
to
7815570
Compare
gigitux
force-pushed
the
fix/flaky-e2e-tests
branch
from
January 24, 2023 09:57
7815570
to
f35cc18
Compare
@gigitux we are on it, still don't understand what's going on though. |
albarin
approved these changes
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes E2E tests. All test fails when Gutenberg is installed because Gutenberg changed the UI regarding the block settings (WordPress/gutenberg#45005):
To fix this issue I upgrade the package
@wordpress/e2e-test-utils
that contains a new utilswitchBlockInspectorTab
to switch the tab. Also, I fixed some failure tests for some updates that we did in our codebase.I disabled the test regarding the
Catalog Sorting
block. Even if they are straightforward, they failed but I don't understand why. Could you take a look, @albarin?Some tests are still flaky. 😢
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility