This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Cleanup Assets class. #3875
Closed
budzanowski
wants to merge
3
commits into
fix/3748-dont-load-wc_blocks_data-on-every-route
from
fix/3868-refactor-assets-class
Closed
Cleanup Assets class. #3875
budzanowski
wants to merge
3
commits into
fix/3748-dont-load-wc_blocks_data-on-every-route
from
fix/3868-refactor-assets-class
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove fix to load our stylesheets after editor CSS. See ...Remove fix to load our stylesheets after editor CSS. See #3068 for the rationale of this fix. It should be no longer github.com/WordPress/gutenberg/issues/20797). https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/5aa2ac1b34cbf9c8f02ab4b97121314ffeea0ebe/src/Domain/AssetsInitialization.php#L58-L71🚀 This comment was generated by the automations bot based on a
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #3868 a new
AssetsInitializaton
class was created in place ofAssets
. The new class is initialized inBootstrap
which matches the pattern used for the initialization of other classes. TheAssets
was stripped-down and only the method that was exposed externally is still in the class body.Fixes #3868
This is based on #3748 so it needs to wait on that.
Changelog