-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipping Labels Onboarding: Pre-install screen #6797
Shipping Labels Onboarding: Pre-install screen #6797
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code: |
import javax.inject.Inject | ||
|
||
@HiltViewModel | ||
class InstallWCShippingViewModel @Inject constructor( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff is misleading, the file was renamed, and this caused Github to mark everything as added, but I think it's not a bad thing, reviewing the file as a whole can make things clearer.
Codecov Report
@@ Coverage Diff @@
## trunk #6797 +/- ##
============================================
- Coverage 45.21% 44.87% -0.34%
Complexity 2964 2964
============================================
Files 531 533 +2
Lines 28962 29181 +219
Branches 3824 3859 +35
============================================
Hits 13094 13094
- Misses 14656 14875 +219
Partials 1212 1212
Continue to review full report at Codecov.
|
@hichamboushaba This is unrelated to this PR, but I just wanted to make sure you were aware of #6674. To me the image looks like it needs some end padding, but perhaps this is what the design called for? |
durationMillis = 500, | ||
delayMillis = 500, | ||
// Ensure a bit of elasticity at the end of the animation | ||
easing = CubicBezierEasing(0.7f, 0.6f, 0.74f, 1.3f) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Thanks for the review @nbradbury
Yes, this is something I missed when I was concentrating on the animations, I'll update the content to make it scrollable.
Both things come from the current designs, I'm not involved in the project from the beginning, but I believe the team discussed those aspects before giving the go to the implementation, and anyway we can always ask the design team if we need to 🙂, @joe-keenan WDYT? |
@nbradbury I tried to fix the issue on landscape with the two commits 30f72ae and 00fe3b6, they make the content scrollable, and add a minimum height for the |
@hichamboushaba I'll approve and merge this, but I wanted to note that having the "Cancel" button scroll seems odd. Just like the back button or a "X" button, shouldn't that stay fixed in place? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of: #6587
Description
This PR adds the following changes:
Testing instructions
Images/gif
Screen.Recording.2022-06-22.at.11.32.45.mov
RELEASE-NOTES.txt
if necessary.