Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipping Labels Onboarding] Small improvements to the CTA scree #6727

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

hichamboushaba
Copy link
Member

Part of: #6586

Description

This PR just adds two small improvements to the WCShip installation onboarding screen:

  1. Make the CTA buttons sticky to the bottom of the screen, while the rest is scrollable.
  2. Fix alignments of the bullet points in landscape.

Testing instructions

To access this new screen a site eligible for shipping labels is required for the #6620 to be displayed inside OrderDetail screen. Conditions for the banner to be shown:

  • The store is located in US.
  • The order currency is USD.
  • The products are eligible for SL (not virtual/downloadable).
  • The order is not eligible for IPP.
  • WC Shipping plugin must be uninstalled or unactive

Once the banner is shown, click on "Get WooCommerce Shipping" button and the new screen should be displayed, please confirm that the above two changes are working as expected.

Images/gif

image

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-woocommerce
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@hichamboushaba hichamboushaba added feature: shipping labels Related to creating, ordering, or printing shipping labels. type: enhancement A request for an enhancement. labels Jun 10, 2022
@hichamboushaba hichamboushaba marked this pull request as ready for review June 10, 2022 15:57
@hichamboushaba hichamboushaba requested a review from nbradbury June 10, 2022 15:57
@wpmobilebot
Copy link
Collaborator

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

@nbradbury nbradbury self-assigned this Jun 10, 2022
Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

@nbradbury nbradbury merged commit 0bed223 into trunk Jun 10, 2022
@nbradbury nbradbury deleted the issue/6586-improve-sl-cta branch June 10, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: enhancement A request for an enhancement.
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

3 participants