[POS Orders] Fetch order when sending receipt if it's not in DB #14817
+73
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toupper
added
type: task
1 task
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
toupper
commented
Oct 24, 2025
...c/main/kotlin/com/woocommerce/android/ui/woopos/emailreceipt/WooPosEmailReceiptRepository.kt
Outdated
Show resolved
Hide resolved
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...st/kotlin/com/woocommerce/android/ui/woopos/emailreceipt/WooPosEmailReceiptRepositoryTest.kt
Fixed
Show fixed
Hide fixed
...st/kotlin/com/woocommerce/android/ui/woopos/emailreceipt/WooPosEmailReceiptRepositoryTest.kt
Fixed
Show fixed
Hide fixed
...st/kotlin/com/woocommerce/android/ui/woopos/emailreceipt/WooPosEmailReceiptRepositoryTest.kt
Fixed
Show fixed
Hide fixed
...st/kotlin/com/woocommerce/android/ui/woopos/emailreceipt/WooPosEmailReceiptRepositoryTest.kt
Fixed
Show fixed
Hide fixed
...st/kotlin/com/woocommerce/android/ui/woopos/emailreceipt/WooPosEmailReceiptRepositoryTest.kt
Fixed
Show fixed
Hide fixed
kidinov
reviewed
Oct 28, 2025
| orderMapper.toAppModel(it) | ||
| } | ||
|
|
||
| suspend fun fetchOrderById(orderId: Long): Order? { |
There was a problem hiding this comment.
Yes, done in 4a8de22
kidinov
reviewed
Oct 28, 2025
| } | ||
|
|
||
| suspend fun fetchOrderById(orderId: Long): Order? { | ||
| val result = withTimeoutOrNull(AppConstants.REQUEST_TIMEOUT) { |
There was a problem hiding this comment.
I think it can be as simple as
suspend fun fetchOrderById(orderId: Long): Order? {
val result = orderStore.fetchSingleOrder(
selectedSite.get(),
orderId
)
return if (!result.isError) {
getOrderById(orderId)
} else {
null
}
}
withTimeoutOrNull looks like it's redundant. There is already a request on timeout in the network layer
There was a problem hiding this comment.
good point, done in 0703601
kidinov
approved these changes
Oct 28, 2025
Base automatically changed from
feat/WOOMOB-1154-POS-Order-details-email-refresh-after
to
trunk
October 29, 2025 13:46
...st/kotlin/com/woocommerce/android/ui/woopos/emailreceipt/WooPosEmailReceiptRepositoryTest.kt
Fixed
Show fixed
Hide fixed
…s://github.com/woocommerce/woocommerce-android into feat/WOOMOB-1154-POS-Order-email-receipt-fetch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #14817 +/- ##
=========================================
Coverage 38.27% 38.27%
- Complexity 10089 10091 +2
=========================================
Files 2132 2132
Lines 120771 120779 +8
Branches 16568 16570 +2
=========================================
+ Hits 46224 46232 +8
+ Misses 69850 69849 -1
- Partials 4697 4698 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOOMOB-1154
Description
From this comment
We fetch the order remotely if it's not in the DB
Test Steps
Open POS after a clean install of the app, and ensure that the receipt is sent.
Images/gif
N/A
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.