-
Notifications
You must be signed in to change notification settings - Fork 133
[WOOMOB-1569] - Rename Pay at location to Pay on site #14809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #14809 +/- ##
=========================================
Coverage 38.21% 38.22%
Complexity 10085 10085
=========================================
Files 2131 2131
Lines 120357 120357
Branches 16476 16476
=========================================
+ Hits 46000 46001 +1
+ Misses 69707 69706 -1
Partials 4650 4650 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻 I just added a minor comment but approving it anyway.
|
|
||
| @LightDarkThemePreviews | ||
| @Composable | ||
| private fun PaymentStatusTagPayAtLocationPreview() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PaymentStatusTagPayAtLocationPreview → this is the last remaining place in the code where ...PayAtLocation is stil used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I missed it!
d0f16c3 to
fd6f23a
Compare
WOOMOB-1569
Description
I've noticed that the badge copy was changed from
Pay at locationtoPay on site. This PR implements that change.Test Steps
cash on deliverypayment method and the order is not completedPay on sitebadge in the listImages/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.