Skip to content

Conversation

@AdamGrzybkowski
Copy link
Contributor

WOOMOB-1569

Description

I've noticed that the badge copy was changed from Pay at location to Pay on site. This PR implements that change.

Test Steps

  1. Make sure you have a booking with cash on delivery payment method and the order is not completed
  2. Launch the booking tab
  3. Verify you see Pay on site badge in the list

Images/gif

Screenshot_20251023_164114
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 23, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitfd6f23a
Direct Downloadwoocommerce-wear-prototype-build-pr14809-fd6f23a.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 23, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitfd6f23a
Direct Downloadwoocommerce-prototype-build-pr14809-fd6f23a.apk

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.22%. Comparing base (c0ee195) to head (fd6f23a).
⚠️ Report is 39 commits behind head on trunk.

Files with missing lines Patch % Lines
...ce/android/ui/bookings/compose/BookingStatusTag.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #14809   +/-   ##
=========================================
  Coverage     38.21%   38.22%           
  Complexity    10085    10085           
=========================================
  Files          2131     2131           
  Lines        120357   120357           
  Branches      16476    16476           
=========================================
+ Hits          46000    46001    +1     
+ Misses        69707    69706    -1     
  Partials       4650     4650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@irfano irfano self-assigned this Oct 23, 2025
Copy link
Contributor

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻 I just added a minor comment but approving it anyway.


@LightDarkThemePreviews
@Composable
private fun PaymentStatusTagPayAtLocationPreview() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PaymentStatusTagPayAtLocationPreview → this is the last remaining place in the code where ...PayAtLocation is stil used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed it!

@AdamGrzybkowski AdamGrzybkowski force-pushed the issue/WOOMOB-1569_pay_on_site branch from d0f16c3 to fd6f23a Compare October 24, 2025 07:53
@AdamGrzybkowski AdamGrzybkowski merged commit 7dd8996 into trunk Oct 24, 2025
16 checks passed
@AdamGrzybkowski AdamGrzybkowski deleted the issue/WOOMOB-1569_pay_on_site branch October 24, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants