Skip to content

[WOOMOB-1474][Woo POS][Surveys] Add analytics tracking for survey notifications. Remove feature flag #14751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

[WOOMOB-1474][Woo POS][Surveys] Add analytics tracking for survey notifications. Remove feature flag #14751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80f5097
Remove feature flag WOO_POS_SURVEYS
kidinov Oct 14, 2025
73f545a
Location notifications already have tracking in them so I just change…
kidinov Oct 14, 2025
06d8158
Updated release notes
kidinov Oct 14, 2025
056de7f
Merge branch 'trunk' into woomob-1474-woo-possurveys-add-analytics
kidinov Oct 15, 2025
365cc3d
Updated release notes
kidinov Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
*** PLEASE FOLLOW THIS FORMAT: [<priority indicator, more stars = higher priority>] <description> [<PR URL>]
*** Use [*****] to indicate smoke tests of all critical flows should be run on the final APK before release (e.g. major library or targetSdk updates).
*** For entries which are touching the Android Wear app's, start entry with `[WEAR]` too.
23.6
-----
- [Internal][Woo POS] Survey for potential and current users of the POS delivered via local push notification. [https://github.com/woocommerce/woocommerce-android/pull/14751]


23.5
-----
- [Internal][Wear] Remove unused dependencies and optimize dependency scopes [https://github.com/woocommerce/woocommerce-android/pull/14710]
Expand Down
4 changes: 2 additions & 2 deletions ...erce/src/main/kotlin/com/woocommerce/android/notifications/local/LocalNotificationType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package com.woocommerce.android.notifications.local
enum class LocalNotificationType(val value: String) {
BLAZE_NO_CAMPAIGN_REMINDER("blaze_no_campaign_reminder"),
BLAZE_ABANDONED_CAMPAIGN_REMINDER("blaze_abandoned_campaign_reminder"),
WOO_POS_SURVEY_POTENTIAL_USER_REMINDER("woo_pos_survey_potential_user_reminder"),
WOO_POS_SURVEY_CURRENT_USER_REMINDER("woo_pos_survey_current_user_reminder");
WOO_POS_SURVEY_POTENTIAL_USER_REMINDER("woo_pos_survey_potential_user_survey"),
WOO_POS_SURVEY_CURRENT_USER_REMINDER("woo_pos_survey_current_user_survey");
override fun toString() = value

companion object {
Expand Down
8 changes: 2 additions & 6 deletions ...otlin/com/woocommerce/android/ui/woopos/common/util/WooPosSurveysNotificationScheduler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import com.woocommerce.android.notifications.local.LocalNotification
import com.woocommerce.android.notifications.local.LocalNotificationScheduler
import com.woocommerce.android.tools.SelectedSite
import com.woocommerce.android.ui.woopos.util.datastore.WooPosPreferencesRepository
import com.woocommerce.android.util.FeatureFlag
import kotlinx.coroutines.flow.first
import org.wordpress.android.fluxc.store.WooCommerceStore
import java.util.concurrent.TimeUnit
Expand All @@ -26,7 +25,7 @@ class WooPosSurveysNotificationScheduler @Inject constructor(
suspend fun schedulePotentialUserSurveyNotification() {
if (!appPrefs.isWooPosSurveyNotificationPotentialUserShown &&
!wooPosPreferencesRepository.wasOpenedOnce.first() &&
areNotificationsAllowed()
isAllowedCountry()
) {
localNotificationScheduler.scheduleNotification(
LocalNotification.WooPosSurveyPotentialUserNotification(
Expand All @@ -39,7 +38,7 @@ class WooPosSurveysNotificationScheduler @Inject constructor(
suspend fun scheduleCurrentUserSurveyNotification() {
if (!appPrefs.isWooPosSurveyNotificationCurrentUserShown &&
wooPosPreferencesRepository.wasOpenedOnce.first() &&
areNotificationsAllowed()
isAllowedCountry()
) {
localNotificationScheduler.scheduleNotification(
LocalNotification.WooPosSurveyCurrentUserNotification(
Expand All @@ -50,9 +49,6 @@ class WooPosSurveysNotificationScheduler @Inject constructor(
}
}

private suspend fun areNotificationsAllowed(): Boolean =
isAllowedCountry() && FeatureFlag.WOO_POS_SURVEYS.isEnabled()

private suspend fun isAllowedCountry(): Boolean {
val countryCode = wooCommerceStore.getSiteSettingsAsync(selectedSite.get())?.countryCode
return countryCode?.lowercase() in ALLOWED_COUNTRIES
Expand Down
2 changes: 0 additions & 2 deletions WooCommerce/src/main/kotlin/com/woocommerce/android/util/FeatureFlag.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ enum class FeatureFlag {
WC_SHIPPING_BANNER,
BETTER_CUSTOMER_SEARCH_M2,
ORDER_CREATION_AUTO_TAX_RATE,
WOO_POS_SURVEYS,
WOO_POS_HISTORICAL_ORDERS_M1,
WOO_POS_LOCAL_CATALOG_M1,
BOOKINGS_MVP;
Expand All @@ -23,7 +22,6 @@ enum class FeatureFlag {

WOO_POS_HISTORICAL_ORDERS_M1,
WC_SHIPPING_BANNER,
WOO_POS_SURVEYS,
BETTER_CUSTOMER_SEARCH_M2,
ORDER_CREATION_AUTO_TAX_RATE,
WOO_POS_LOCAL_CATALOG_M1,
Expand Down