[WOO POS] UI tests for Product and Cart screens #12713

AnirudhBhat · 2024-09-27T03:10:36Z

Closes: #12702

Description

This PR adds UI tests for Product and Cart screens of POS.

Testing information

Ensure the CI is happy - specifically, UI test pipeline is green.

The tests that have been performed

Add UI test to verify Products screen is displayed when POS mode is entered
Add UI test to verify Cart item is added when product item is clicked
Add UI test to verify Checkout button is not displayed when the cart list is empty
Add UI test to verify different cases of Checkout button visibility
Add UI test to verify cart item removal functionality
Add UI test to verify clicking Checkout button transitions to Checkout screen and hides Products screen
Add UI test to verify clicking Checkout button transitions to Checkout screen and displays Totals screen
Add UI test to verify clicking Checkout button transitions to Checkout screen and displays "Collect Payment" button

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

Previously, we were assigning the charts value to itself, and it was making the logic harder to follow.

Update release notes for 20.4

Merge release/20.4 into trunk

This reverts commit 769b21b.

Remove modifier param because we don't really want to allow overriding it.

…cker

…ui-issues [Woo POS] Totals calculation app-side issue

…banner Issue/12597 custom fields banner

…red.

… the product is added, the same product is added to cart.

… cart list is not shown.

…t list has items.

… cart items are removed

…he checkout screen.

…n is clicked.

…en when the checkout button is clicked.

dangermattic · 2024-09-27T03:12:44Z

	10 Errors
🚫	Please ensure the PR has the `category: tracks` label.
🚫	Please add tests for class `ProductImagePickerViewModel` (or add `unit-tests-exemption` label to ignore this).
🚫	Please add tests for class `AbandonedCampaignReminder` (or add `unit-tests-exemption` label to ignore this).
🚫	Please add tests for class `AztecViewsHolder` (or add `unit-tests-exemption` label to ignore this).
🚫	Please add tests for class `AztecEditorState` (or add `unit-tests-exemption` label to ignore this).
🚫	Please add tests for class `ComposeWebChromeClient` (or add `unit-tests-exemption` label to ignore this).
🚫	Please add tests for class `UiState` (or add `unit-tests-exemption` label to ignore this).
🚫	Please add tests for class `OptionalVariantAttribute` (or add `unit-tests-exemption` label to ignore this).
🚫	Please add tests for class `Toast` (or add `unit-tests-exemption` label to ignore this).
🚫	Please add tests for class `RotationDirection` (or add `unit-tests-exemption` label to ignore this).

	1 Warning
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

	2 Messages
📖	This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed: The tracks events must be validated in the Tracks system. Verify the internal Tracks spreadsheet has also been updated. Please consider registering any new events. The PR must be assigned the category: tracks label.
📖	This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

wpmobilebot · 2024-09-27T03:16:42Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`4a5573e`
	Direct Download	`woocommerce-wear-prototype-build-pr12713-4a5573e.apk`

wpmobilebot · 2024-09-27T03:30:31Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`4a5573e`
	Direct Download	`woocommerce-prototype-build-pr12713-4a5573e.apk`

… data

…een-pos # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/WooPosHomeScreen.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/cart/WooPosCartScreen.kt

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/compose/component/Switch.kt


 @Composable
 private fun defaultSwitchColors(): SwitchColors =
    SwitchDefaults.colors(checkedThumbColor = MaterialTheme.colors.primary)

+@Composable
+fun BottomSheetSwitchColors(): SwitchColors =


WooCommerce/src/main/kotlin/com/woocommerce/android/ui/compose/component/aztec/AztecEditor.kt

+        Aztec.with(viewsHolder.visualEditor, viewsHolder.sourceEditor, viewsHolder.toolbar, listener)
+            .setImageGetter(GlideImageLoader(localContext))
+    }
+    var sourceEditorMinHeight by rememberSaveable { mutableStateOf(0) }


WooCommerce/src/main/res/values-de/strings.xml

+    <string name="woopos_dialog_exit_confirmation_background_content_description">Abgedunkelter Hintergrund. Zum Schließen des Dialogs tippen.</string>
+    <string name="blaze_campaign_budget_weekly_spending">%1$s wöchentlich</string>
+    <string name="blaze_campaign_budget_duration_endless_label">Ausführen, bis ich sie beende</string>
+    <string name="blaze_campaign_budget_duration_endless_campaign_value">Seit dem %1$s</string>


WooCommerce/src/main/res/values/strings.xml

-    <string name="blaze_campaign_budget_duration_bottom_sheet_starts">Starts</string>
+    <string name="blaze_campaign_budget_duration_bottom_sheet_end_date">to %1$s</string>
+    <string name="blaze_campaign_budget_duration_bottom_sheet_start_date">Start date</string>
+    <string name="blaze_campaign_budget_duration_endless_label">Run until I stop it</string>


wpmobilebot and others added 30 commits September 13, 2024 06:17

Release Notes: add new section for next version (20.5)

da0049d

Make sure to clear the chart if the stats are empty

90095e0

Improve logic of the function

40b4638

Previously, we were assigning the charts value to itself, and it was making the logic harder to follow.

Bump fluxc

9b11973

Update release notes for 20.4

7c128df

Display product images upon tapping in new option

d2c92ad

Merge pull request #12606 from woocommerce/update-release-notes-20.4

7f05b19

Update release notes for 20.4

Update PlayStoreStrings.po for 20.4

3c8d016

Freeze strings for translation

ba57fe1

Update product selected image

a9dd531

Update product images UI for adaptive grid

40e8edf

Merge pull request #12607 from woocommerce/merge/release-20.4-into-trunk

9acb6ce

Merge release/20.4 into trunk

Update CI toolkit to 3.6.2

9c19016

temp: add lint violation

769b21b

Do not use ignore case when renaming attributes

00401b5

Revert "temp: add lint violation"

cbd41b6

This reverts commit 769b21b.

Add unit test

d0720ba

Add toolbar and title to product photo picker

c6cd96e

Clean up code

482eb97

Remove modifier param because we don't really want to allow overriding it.

Align padding

ded7106

Handle empty case for product image picker

0650c0b

Fix detekt indentation issues

c332c70

Fix title of photo picker

b84c63d

Add release note

5a54835

Update release notes

7e9a5f4

Merge branch 'refs/heads/trunk' into issue/11323-new-product-image-pi…

0827072

…cker

Update release notes

ce884db

Remove compose code duplication

31cfd61

Merge branch 'trunk' into 12496-totals-calculations-ui-issues

9169112

Merge pull request #12583 from woocommerce/12496-totals-calculations-…

2ada792

…ui-issues [Woo POS] Totals calculation app-side issue

hichamboushaba and others added 19 commits September 25, 2024 09:14

Merge pull request #12601 from woocommerce/issue/12597-custom-fields-…

cdf6e5b

…banner Issue/12597 custom fields banner

Add test to verify Products screen is displayed when POS mode is ente…

7fd1205

…red.

Remove unused import

7da9cb7

Add test tag for each of the cart item

f6a7abb

Add test tag for each of the product item

469f597

Add test to verify that the cart wil be empty initially and then when…

089f9cf

… the product is added, the same product is added to cart.

Add test to verify that the checkout button is not displayed when the…

a8242a5

… cart list is not shown.

Add test to verify that the checkout button is displayed when the car…

597a872

…t list has items.

Remove unused imports

b58625d

Add test to verify that the checkout button is not displayed when the…

2c0eb52

… cart items are removed

Rename test name for better understanding

b7cc385

Add test to verify cart removal functionality works fine.

55ec979

Add test to verify clicking on checkout button hides product screen

f344e10

Add test to verify checkout button is not displayed when we move to t…

399e665

…he checkout screen.

Add test tag for the totals screen

a360a64

Add test to verify totals screen is displayed when the checkout butto…

395b344

…n is clicked.

Add test to verify Collect payment button is displayed in totals scre…

3233b92

…en when the checkout button is clicked.

Fix detekt errors

18c91e0

Remove unnecessary test

d8a8bb3

AnirudhBhat added the Testing label Sep 27, 2024

AnirudhBhat added 6 commits September 27, 2024 12:49

Fix failing test

08af8ef

Use real API test data for tests

4194b44

Fix test failure

bc77616

Revert back changes as it looks like UI test do not use real api test…

6ef3406

… data

Merge branch 'refs/heads/trunk' into issue/12702-ui-tests-product-scr…

c9e8af4

…een-pos # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/WooPosHomeScreen.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/cart/WooPosCartScreen.kt

Fix test tag

4a5573e

github-advanced-security bot found potential problems Oct 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WOO POS] UI tests for Product and Cart screens #12713

[WOO POS] UI tests for Product and Cart screens #12713

AnirudhBhat commented Sep 27, 2024

dangermattic commented Sep 27, 2024 •

edited

Loading

wpmobilebot commented Sep 27, 2024 •

edited

Loading

wpmobilebot commented Sep 27, 2024 •

edited

Loading

[WOO POS] UI tests for Product and Cart screens #12713

Are you sure you want to change the base?

[WOO POS] UI tests for Product and Cart screens #12713

Conversation

AnirudhBhat commented Sep 27, 2024

Description

Testing information

The tests that have been performed

Reviewer (or Author, in the case of optional code reviews):

dangermattic commented Sep 27, 2024 • edited Loading

wpmobilebot commented Sep 27, 2024 • edited Loading

wpmobilebot commented Sep 27, 2024 • edited Loading

dangermattic commented Sep 27, 2024 •

edited

Loading

wpmobilebot commented Sep 27, 2024 •

edited

Loading

wpmobilebot commented Sep 27, 2024 •

edited

Loading