-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/switch feed v5 #849
Add/switch feed v5 #849
Conversation
to automate merging trunk to develop after a release
… based on store currency.
…with currency using wc_price function.
…edits given." This reverts commit 3e9c12b.
…ds promo and onboarding modal.
…erms and Conditions modal and Landing page flexbox.
Fix uninstall procedure.
… based on currency (#812)
New v5 API does not have any analog of pinterest-for-woocommerce/src/FeedRegistration.php Lines 233 to 236 in d41ee8e
|
I think that for now, we will need to operate based on the |
… into add/switch-feed-v5
…ing recent feed processing status endpoint.
…id of Merchant object as the one not needed with v5.
…Adjusting create feed endpoint to provide a unique feed name. Reverting back some Base API method names.
…m the current website
…h renewed WP and PHP versions.
# Conflicts: # class-pinterest-for-woocommerce.php # composer.json # composer.lock # src/API/Auth.php # src/API/Base.php # src/Merchants.php
…nd to allow x.x.x versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of a develop merge will give us a nice base for full rebase.
9650be5
into
pinterest-v5-integration-branch
Changes proposed in this Pull Request:
Closes #833 .
Adds Pinterest API v5 integration into feeds.
Merging
develop
in as well to catch up on fresh phpcs and unit tests setups.Detailed test instructions:
add/switch-feed-v5
branch.pinterest-for-woocommerce-handle-feed-registration
action.NOTE: Checks feed's Language column, it must be the same you have under your WordPress Settings.
Changelog entry