Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/switch feed v5 #849

Merged
merged 85 commits into from
Dec 22, 2023
Merged

Conversation

message-dimke
Copy link
Contributor

@message-dimke message-dimke commented Nov 10, 2023

Changes proposed in this Pull Request:

Closes #833 .

Adds Pinterest API v5 integration into feeds.
Merging develop in as well to catch up on fresh phpcs and unit tests setups.

Detailed test instructions:

  1. Checkout add/switch-feed-v5 branch.
  2. Check Product Sync being at Settings tab.
Settings_‹_Pinterest_‹_Marketing_‹_WooCommerce_‹_WordPress_Pinterest_—_WooCommerce
  1. Go to WooCommerce - Status - Scheduled Actions - Pending tab and force run pinterest-for-woocommerce-handle-feed-registration action.
WooCommerce_status_‹_WordPress_Pinterest_—_WordPress
  1. Go to Pinterest and check for the feed to be present and active under Catalogues - Data Sources
  • Feed name must be like "Created by Pinterest for WooCommerce [country(Site Language)]-[currency]."
  • Feed must have Active Status

NOTE: Checks feed's Language column, it must be the same you have under your WordPress Settings.

Pinterest Pinterest
  1. Go to WordPress Settings and change Site Language to something else of your choice. I switched between US and UK English languages.
General_Settings_‹_WordPress_Pinterest_—_WordPress
  1. Check Pinterest Catalogues - Data Sources for another feed to be added and activated.
Pinterest

Changelog entry

Add - Pinterest API v5 feeds integration.

tomalec and others added 30 commits July 24, 2023 17:19
to automate merging trunk to develop after a release
…erms and Conditions modal and Landing page flexbox.
@message-dimke message-dimke self-assigned this Nov 10, 2023
@message-dimke message-dimke changed the base branch from develop to pinterest-v5-integration-branch November 10, 2023 12:37
@message-dimke
Copy link
Contributor Author

New v5 API does not have any analog of integration_platform_type for the feed which we are using to make sure we disable only feeds we created.

// Only disable feeds that are registered as WooCommerce integration.
if ( 'WOOCOMMERCE' !== $feed->integration_platform_type ) {
continue;
}

@budzanowski
Copy link
Collaborator

I think that for now, we will need to operate based on the location only.

…id of Merchant object as the one not needed with v5.
…Adjusting create feed endpoint to provide a unique feed name. Reverting back some Base API method names.
# Conflicts:
#	class-pinterest-for-woocommerce.php
#	composer.json
#	composer.lock
#	src/API/Auth.php
#	src/API/Base.php
#	src/Merchants.php
@message-dimke message-dimke marked this pull request as ready for review November 29, 2023 21:11
Copy link
Collaborator

@budzanowski budzanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

The addition of a develop merge will give us a nice base for full rebase.

@message-dimke message-dimke merged commit 9650be5 into pinterest-v5-integration-branch Dec 22, 2023
9 checks passed
@message-dimke message-dimke deleted the add/switch-feed-v5 branch December 22, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch Feed operations to V5
8 participants