Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkbox control UI issue with WordPress 6.6 #1034

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix checkbox control UI issue with WordPress 6.6 #1034

merged 1 commit into from
Jul 9, 2024

Conversation

ecgan
Copy link
Member

@ecgan ecgan commented Jul 8, 2024 •
edited
Loading

Changes proposed in this Pull Request:

Closes #1033.

In this PR, we fix the checkbox control UI issue with WordPress 6.6.

The fix here is done by referring to the cause of issue mentioned in #1033. We specify the --checkbox-input-size CSS variable so that the checkbox control has a defined width and height.

Screenshots:

Screenshot 2024-07-09 at 12 28 54 AM

Detailed test instructions:

  1. Make sure that you use WordPress 6.6.
  2. Go to the extension settings page: /wp-admin/admin.php?page=wc-admin&path=%2Fpinterest%2Fsettings
  3. The checkbox controls should be displayed nicely as shown in the screenshot above.
  4. Do some exploratory testing to make sure that the CSS changes in this PR does not breaking anything.
  5. Downgrade WordPress to older version (e.g. version 6.5). Repeat the above testing to make sure that the CSS changes in this PR works well with older WordPress version.

@ecgan ecgan requested a review from a team July 8, 2024 16:37
@ecgan ecgan self-assigned this Jul 8, 2024
@message-dimke message-dimke requested review from message-dimke and removed request for a team July 8, 2024 20:04
message-dimke
message-dimke approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@message-dimke message-dimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I confirm the fix works and makes this

Settings_‹_Pinterest_‹_Marketing_‹_WooCommerce_‹_WordPress_Pinterest_—_WooCommerce

into this

Settings_‹_Pinterest_‹_Marketing_‹_WooCommerce_‹_WordPress_Pinterest_—_WooCommerce-2

Thank you, @ecgan !

@ecgan ecgan merged commit ef06d1b into develop Jul 9, 2024
3 checks passed
@ecgan ecgan deleted the feature/wp-6.6-fix-checkbox-ui branch July 9, 2024 07:31
layoutd pushed a commit that referenced this pull request Jul 23, 2024
@ecgan @layoutd
Merge pull request #1034 from woocommerce/feature/wp-6.6-fix-checkbox-ui
1301fa2 
Fix checkbox control UI issue with WordPress 6.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@message-dimke message-dimke message-dimke approved these changes

Assignees

@ecgan ecgan

Labels
category: compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox UI issue with WordPress 6.6
2 participants
@ecgan @message-dimke