JNI/JSSE: optimize out array creation in WolfSSLEngine RecvAppData() #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pass ByteBuffer down to JNI directly
cconlon
force-pushed
the
sslEngineOptimization
branch
from
2c6868c to
12eae28
Compare
JacobBarthelmeh
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimization PR that removes an extra
byte[]array creation insideWolfSSLEngine.RecvAppData(), which is called fromSSLEngine.unwrap().Prior to this PR, we allocated a new
byte[]to read ByteBuffer data into and pass down to JNI forSSL_read()operations.This PR changes that behavior so that if there is only one
ByteBufferin the outputByteBuffer[]passed tounwrap(), that ByteBuffer is passed down to JNI directly where the underlying array is retrieved and used without an extra array creation.This should have positive impacts on reducing the number of objects created, especially in use cases where lots of data is being received (or downloaded) via an
SSLEngine.unwrap()interface.