fix to sanity check on importing raw session key info#9973
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Mar 16, 2026
Merged
fix to sanity check on importing raw session key info#9973dgarske merged 1 commit intowolfSSL:masterfrom
dgarske merged 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the bounds check when importing raw session key material to correctly account for skipping two chunks of size sz.
Changes:
- Updates the length check from
sz + idxto(sz * 2) + idxbefore advancingidxtwice.
Comments suppressed due to low confidence (1)
src/internal.c:1
- The updated check correctly accounts for two
szadvances, but(sz * 2) + idxcan overflow (and wrap) ifsz/idxare unsigned, potentially bypassing the bounds check and leading to out-of-bounds reads later. Prefer an overflow-safe formulation (e.g., compare using division or subtract-first): checkidx > lenfirst (if not guaranteed elsewhere), then validatesz > (len - idx) / 2(or equivalent) before doingidx += sztwice.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
SparkiDev
approved these changes
Mar 16, 2026
Contributor
Author
|
Retest this please Jenkins |
dgarske
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.