-
Notifications
You must be signed in to change notification settings - Fork 915
Fix qt jenkins nightly test failure #9584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🛟 Devin Lifeguard found 3 likely issues in this PR
@miyazakh |
|
retest this please
|
|
retest this please
|
|
retest this please |
julek-wolfssl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also one comment from previous review is not fixed.
fix indentation
|
retest this please |
|
retest this please
|
Description
Qt nightly Jenkins tests started failing after PR9522 was merged. OpenSSL performs date validation even when there are other verification issues. This PR reverts the removed logic and now uses X509StoreVerifyCertDate().
Testing
Add unit test
Run qt unit test
Checklist