20250206-unit-test-helgrind-fixes #8423
Open
+44
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() using a mutex, and in test_wolfSSL_dtls_AEAD_limit() using a mutex, an atomic integer, and a volatile attribute. wolfssl/wolfcrypt/wc_port.h: add WOLFSSL_ATOMIC_LOAD() and WOLFSSL_ATOMIC_STORE() definitions.
|
retest this please (PRB master job didn't do anything) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/api.c: fix data races intest_wolfSSL_CTX_add_session_ctx_ready()using a mutex, and intest_wolfSSL_dtls_AEAD_limit()using a mutex, an atomic integer, and avolatileattribute.wolfssl/wolfcrypt/wc_port.h: addWOLFSSL_ATOMIC_LOAD()andWOLFSSL_ATOMIC_STORE()definitions.tested with
wolfssl-multi-test.sh ... quantum-safe-wolfssl-all-intelasm-sp-asm-helgrind check-source-text(
quantum-safe-wolfssl-all-intelasm-sp-asm-helgrindis a new test)Note, also tried testing using
valgrind --tool=drdbut saw various nondeterministic failures, in e.g.test_wolfSSL_UseALPN_connection,test_wolfSSL_BIO_accept, and particularly,test_ticket_and_psk_mixing_on_result. Not yet known if true or false positive.