Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for building wolfSSL in Visual Studio #7040

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Dec 6, 2023

Description

Fixes for building wolfSSL in Visual Studio. Adds missing files. Fix for type cast warnings.

Note: There are still several ASN and PKCS7 warnings about potentially uninitialized local variables.

1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\pkcs7.c(11953): warning C4701: potentially uninitialized local variable 'tag' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\pkcs7.c(12784): warning C4701: potentially uninitialized local variable 'tag' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\pkcs7.c(12852): warning C4701: potentially uninitialized local variable 'version' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\pkcs7.c(4598): warning C4701: potentially uninitialized local variable 'outerContentType' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\pkcs7.c(10756): warning C4701: potentially uninitialized local variable 'length' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\pkcs7.c(10646): warning C4701: potentially uninitialized local variable 'contentType' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\pkcs7.c(10659): warning C4701: potentially uninitialized local variable 'tag' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\pkcs7.c(4374): warning C4701: potentially uninitialized local variable 'length' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\pkcs7.c(4314): warning C4701: potentially uninitialized local variable 'version' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(3450): warning C4701: potentially uninitialized local variable 'bits' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(6845): warning C4701: potentially uninitialized local variable 'version' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(7146): warning C4701: potentially uninitialized local variable 'sz' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(8781): warning C4701: potentially uninitialized local variable 'version' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(8821): warning C4701: potentially uninitialized local variable 'iterations' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(15784): warning C4701: potentially uninitialized local variable 'sz' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(29093): warning C4701: potentially uninitialized local variable 'sz' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(32739): warning C4701: potentially uninitialized local variable 'version' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(33427): warning C4701: potentially uninitialized local variable 'privSz' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(33447): warning C4701: potentially uninitialized local variable 'pubSz' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(14139): warning C4701: potentially uninitialized local variable 'len' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(21760): warning C4701: potentially uninitialized local variable 'version' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(21192): warning C4701: potentially uninitialized local variable 'version' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(21203): warning C4701: potentially uninitialized local variable 'serialSz' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(28068): warning C4701: potentially uninitialized local variable 'sz' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(26662): warning C4701: potentially uninitialized local variable 'piSz' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(19586): warning C4701: potentially uninitialized local variable 'entry' used
1>C:\Users\David Garske\Documents\wolfssl\wolfcrypt\src\asn.c(19586): warning C4703: potentially uninitialized local pointer variable 'entry' used

Testing

See: wolfSSL/wolfTPM#316

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske self-assigned this Dec 6, 2023
@dgarske
Copy link
Contributor Author

dgarske commented Dec 7, 2023

Failure was in a DTLS test unrelated to my changes. Retest this please.

@JacobBarthelmeh JacobBarthelmeh merged commit 9d0bb4c into wolfSSL:master Dec 7, 2023
92 checks passed
@dgarske dgarske deleted the win_vs branch December 19, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants