Add comment about using TPM based RNG for start auth nonce#478
Open
dgarske wants to merge 1 commit intowolfSSL:masterfrom
Open
Add comment about using TPM based RNG for start auth nonce#478dgarske wants to merge 1 commit intowolfSSL:masterfrom
dgarske wants to merge 1 commit intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds security-focused documentation to discourage using TPM RNG output over SPI/I2C for session nonce generation unless the bus is physically protected, and makes the local wolfCrypt RNG the documented default for nonce generation.
Changes:
- Expanded
wolfTPM2_GetRng()documentation to warn about HW RNG data exposure on SPI/I2C. - Added rationale comment for defaulting to local wolfCrypt RNG (when available) instead of
TPM2_GetRandom. - Updated
TPM2_GenNonce()documentation to warn about nonce tampering risk when usingWOLFTPM2_USE_HW_RNG.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| wolftpm/tpm2_wrap.h | Adds Doxygen warning around using TPM RNG over an unprotected bus. |
| wolftpm/tpm2.h | Documents default nonce RNG choice and updates nonce-generation API docs with a bus-tampering warning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZD 21476