Skip to content

wolfPKCS11 test#731

Draft
danielinux wants to merge 11 commits intowolfSSL:masterfrom
danielinux:wolfPKCS11_test
Draft

wolfPKCS11 test#731
danielinux wants to merge 11 commits intowolfSSL:masterfrom
danielinux:wolfPKCS11_test

Conversation

@danielinux
Copy link
Member

@danielinux danielinux commented Mar 20, 2026

  • move pkcs11/tz test to its own module in test-app
  • add m33mu two-runs test for persistent storage coverage

Copilot AI review requested due to automatic review settings March 20, 2026 16:37
@danielinux danielinux changed the title Wolf pkcs11 test wolfPKCS11 test Mar 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings March 20, 2026 17:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 20, 2026 18:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

Makefile:1

  • This change removes the previous || true behavior, making signing failures stop the build. That’s a significant behavior change and isn’t mentioned in the PR description (which focuses on PKCS11 tests). If the intent is to make signing errors fatal, please call it out in the PR description; if not, consider restoring the prior non-fatal behavior for this target.
## wolfBoot Makefile

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 20, 2026 19:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 21, 2026 08:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants