Skip to content

Fix embedded images built with the clang compiler#730

Open
danielinux wants to merge 7 commits intowolfSSL:masterfrom
danielinux:clang-linker
Open

Fix embedded images built with the clang compiler#730
danielinux wants to merge 7 commits intowolfSSL:masterfrom
danielinux:clang-linker

Conversation

@danielinux
Copy link
Member

zd21378

Copilot AI review requested due to automatic review settings March 19, 2026 22:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses oversized/sparse embedded images produced when building with clang by adjusting linking and objcopy behavior for clang-based builds.

Changes:

  • Add clang-specific objcopy section filtering to avoid producing huge sparse binary/hex/srec outputs.
  • Switch clang builds to use the GNU linker driver to preserve LMAs in the linker script.
  • Relax clang build warnings around unknown attributes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
test-app/Makefile Introduces clang-specific objcopy flags and applies them to image artifact generation to prevent sparse outputs.
arch.mk Changes clang toolchain linking to use GNU linker driver and adds clang warning suppressions for unknown attributes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 23, 2026 17:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 23, 2026 18:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants