[delta] Add bounds checks for delta image#693
Merged
dgarske merged 4 commits intowolfSSL:masterfrom Feb 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds source-buffer bounds checks in the delta patch application logic (wb_patch) and introduces unit tests to validate failure behavior on out-of-range source offsets, addressing an issue found via Fenrir/M-29.
Changes:
- Add bounds validation for source reads in
wb_patch()beforememcpy()during normal and resume matching. - Add new unit tests to ensure
wb_patch()returns-1on invalid source offsets (both header-driven and resume-state driven).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/delta.c |
Adds runtime bounds checks to prevent reading past src_base/src_size when applying a delta patch. |
tools/unit-tests/unit-delta.c |
Adds two negative tests covering out-of-bounds source offsets during patch application. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found via Fenrir/M-29